View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005038 | Spring engine | Lua | public | 2016-01-17 16:09 | 2016-01-18 00:11 |
| Reporter | Jools | Assigned To | Kloot | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 100.0+git | ||||
| Fixed in Version | 100.0+git | ||||
| Summary | 0005038: Unable to use chataction before gameframe #2 | ||||
| Description | Background: You cannot reload luaui from a widget by issuing SendCommands("luaui reload"), so it can therefore be done from a gadget instead.An example is posted here: https://github.com/xta-springrts/xta-springrts/blob/master/luarules/gadgets/cmd_luaui_reload.lua Problem #1: The "AddChatAction" command doesn't work before gameframe #2, as handled by SyncedGameCommands.cpp: https://github.com/spring/spring/blob/develop/rts/Game/SyncedGameCommands.cpp#L269 Problem #2: The error message that is sent is sent to all players, not just the player trying to push the reload luaui button. Fix: remove the framenumber requirement, maybe only for unsynced luarules state if possible? Or why is it needed? | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
the framenumber requirement was there for historical reasons and pertained to reloading, not chat actions. note because I happened to see it: this https://github.com/xta-springrts/xta-springrts/commit/d5f10e0241abb75c38d809f8676bea82e925d760 is not the latest gadget handler. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-01-17 16:09 | Jools | New Issue | |
| 2016-01-18 00:11 | Kloot | Note Added: 0015536 | |
| 2016-01-18 00:11 | Kloot | Status | new => resolved |
| 2016-01-18 00:11 | Kloot | Fixed in Version | => 100.0+git |
| 2016-01-18 00:11 | Kloot | Resolution | open => fixed |
| 2016-01-18 00:11 | Kloot | Assigned To | => Kloot |
