View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004975 | Spring engine | General | public | 2015-09-28 16:12 | 2016-01-16 14:31 |
| Reporter | jamerlan | Assigned To | hokomoko | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | reopened | ||
| Product Version | 100.0 | ||||
| Target Version | 101.0 | ||||
| Summary | 0004975: air transport: loading + unloading bugs | ||||
| Description | Take a look at this short video: https://youtu.be/MiBDEqlCSxk | ||||
| Steps To Reproduce | 1) give area load command - not all transports loaded units 2) give unload command - some units will have a super speed and will do a crazy moves | ||||
| Additional Information | replay is attached Spring engine 100 Balanced Annihilation 9.10 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
group unload is just an example. Often the same bug happens with 1 transport. Maybe it is related to unloading near other unit.. I am not sure |
|
|
afaik transporting is completely reworked for spring 101, so very likely every bug report related to transporting on spring 100.0 is invalid. sadly the changes are not finished yet, so i can't advice "please test if its fixed in current dev version" also see https://springrts.com/phpbb/viewtopic.php?f=12&t=33843 edit: an other example for this bug: https://springrts.com/phpbb/viewtopic.php?f=11&t=33903 |
|
|
Actually, legacy transporting shouldn't change, so I think this bug is still present. |
|
|
This seems related to unit collision not working when transported unit is unloaded until it moves. When the air transport would try to land nearby sometimes wtf would happen and the ground unit would start sliding in one direction. I think I fixed this on my game with a gadget that orders unloaded units to move slightly forward a few frames after being unloaded. (check the attached air_transports.lua : the gadget has extra code to slow air transports depending on mass which was the original intent) |
|
|
I'm tempted to say it's the game's responsibility to make sure the collision volumes don't intersect after detaching. |
|
|
we fixed these bugs in BA using workarounds, gadgets etc.. so it is OK if you decide to close it :-) why not all transports loaded units? with area load |
|
|
I got sick of this bug. I fixed it by increasing transport acceleration and WAITWAITing failed transports. What was your fix? This script contains the fix: https://github.com/ZeroK-RTS/Zero-K/blob/master/scripts/corvalk.lua#L232 I did not find any bug related to their collision volumes. |
|
|
Google_Frog, are you asking about units sliding bug? Is "area load" bug fixed in your script? I was wrong. Sliding bug was not fixed in BA. Raaar's script air_transports.lua (attached to this report, it contains a workaround) was added to ba. But actually we excluded this workaround from it: http://imolarpg.dyndns.org/trac/balatest/browser/trunk/luarules/gadgets/air_transports.lua And we use gluon's script to fix unload bug: http://imolarpg.dyndns.org/trac/balatest/browser/trunk/luarules/gadgets/air_transports_fix.lua Sometimes we had situations when you give "unload" order -> transport fly to unload destination -> unload order cancelled. |
|
|
What's the current status regarding that? |
|
|
this sliding bug is still present. But it happens less often |
|
|
Did you check the collision volume overlap? |
|
|
Fix 06c5f345269cbf34090ba8fe97acccdef76fab19 committed to develop branch: Temporarily turn off collision with unloaded units Should fix 0004975, repo: spring changeset id: 6288 |
|
|
Can you test with latest version? |
|
|
probably unloading is fixed.. but looks like issue is more general: replay https://www.dropbox.com/s/kajw7geyc7qr5k1/20160115_222105_DeltaSiegeDry_100.0.1-862-g95174ff%20develop.sdf.gz?dl=0 video: https://youtu.be/teGq0SRZEzQ?t=1m28s and https://youtu.be/teGq0SRZEzQ?t=1m58s |
|
|
I think most of these issues occur when multiple transports try to pick up a single target. |
|
|
Thanks a lot for your help! I am scared of hacks in the engine.. "Temporarily turn off collision with unloaded units" sounds like a complicated hack. We discovered that issue is more general - probably it is better to revert your commit (just a guess - maybe it is not a hack). If it is possible to set smth like: "hey transport - you are not allowed to push any unit!" on the game side - then it is probably better to fix on the game side |
|
|
It wasn't a hack really, just ignore collisions with a unit you have just unloaded as long as you're still overlapping. Makes sense even. you may want to increase the mass of your commanders, or conversely make transports non-collidable at all for a while if you want to do stuff on the game's side |
|
|
hm.. mass of commanders = 5000 (btw this bug with all units - for example with constructors too): http://imolarpg.dyndns.org/trac/balatest/browser/trunk/units/armcom.lua http://imolarpg.dyndns.org/trac/balatest/browser/trunk/units/corcom.lua and mass of air transport is not specified: http://imolarpg.dyndns.org/trac/balatest/browser/trunk/units/armatlas.lua => it equals buildCostMetal => mass of this unit is just 68 (https://springrts.com/wiki/Gamedev:UnitDefs) Looks like unit with a small mass can "push" unit with much bigger mass. Btw, if I need to increase mass of commanders -> then I need to increase transportmass = 5000 of air transport -> that will affect other units too :-) |
|
|
Fix 096d223ee975915e526562444d6be85b667eba4c committed to develop branch: fix 0004975, repo: spring changeset id: 6299 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-28 16:12 | jamerlan | New Issue | |
| 2015-09-28 16:12 | jamerlan | File Added: 20150928_170313_DeltaSiegeDry_100.sdf | |
| 2015-09-28 16:23 | jamerlan | Note Added: 0015253 | |
| 2015-09-28 18:57 | abma | Relationship added | related to 0004974 |
| 2015-09-28 18:59 | abma | Note Added: 0015254 | |
| 2015-09-29 14:02 | hokomoko | Note Added: 0015255 | |
| 2015-09-29 14:02 | hokomoko | Note Edited: 0015255 | |
| 2015-10-02 06:46 | abma | Note Edited: 0015254 | |
| 2015-10-02 06:47 | abma | Target Version | => 101.0 |
| 2015-10-04 05:30 | raaar | File Added: air_transports.lua | |
| 2015-10-04 05:35 | raaar | Note Added: 0015272 | |
| 2015-12-02 00:18 | hokomoko | Note Added: 0015358 | |
| 2015-12-02 05:56 | jamerlan | Note Added: 0015359 | |
| 2015-12-02 13:05 | Google_Frog | Note Added: 0015361 | |
| 2015-12-02 19:13 | jamerlan | Note Added: 0015362 | |
| 2016-01-14 00:57 | hokomoko | Note Added: 0015508 | |
| 2016-01-14 00:57 | hokomoko | Assigned To | => hokomoko |
| 2016-01-14 00:57 | hokomoko | Status | new => feedback |
| 2016-01-14 06:21 | jamerlan | Note Added: 0015514 | |
| 2016-01-14 06:21 | jamerlan | Status | feedback => assigned |
| 2016-01-14 10:52 | hokomoko | Note Added: 0015515 | |
| 2016-01-15 18:17 | hokomoko | Changeset attached | => spring develop 06c5f345 |
| 2016-01-15 18:17 | hokomoko | Note Added: 0015528 | |
| 2016-01-15 18:17 | hokomoko | Status | assigned => resolved |
| 2016-01-15 18:17 | hokomoko | Resolution | open => fixed |
| 2016-01-15 18:18 | hokomoko | Note Added: 0015529 | |
| 2016-01-15 18:18 | hokomoko | Status | resolved => feedback |
| 2016-01-15 18:18 | hokomoko | Resolution | fixed => reopened |
| 2016-01-15 20:43 | jamerlan | Note Added: 0015530 | |
| 2016-01-15 20:43 | jamerlan | Status | feedback => assigned |
| 2016-01-15 22:31 | hokomoko | Note Added: 0015531 | |
| 2016-01-16 09:52 | jamerlan | Note Added: 0015532 | |
| 2016-01-16 10:53 | hokomoko | Note Added: 0015533 | |
| 2016-01-16 11:31 | jamerlan | Note Added: 0015534 | |
| 2016-01-16 14:31 | Changeset attached | => spring develop 096d223e | |
| 2016-01-16 14:31 | Anonymous | Note Added: 0015535 | |
| 2016-01-16 14:31 | Anonymous | Status | assigned => resolved |
