View Issue Details

IDProjectCategoryView StatusLast Update
0004813Spring engineGeneralpublic2015-06-18 01:07
Reporterraaar Assigned Tohokomoko  
PriorityimmediateSeverityblockReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version98.0.1+git 
Target Version99.0 
Summary0004813: gunships stop mid-air and start vibrating
Descriptiongunships stop mid-air and start vibrating

this happens when they were supposed to be attacking targets or landing on repair pad
Steps To Reproduce- start xta 9.745

- spawn an air repair pad

- spawn 10 arm_brawler

- spawn 20 core_crasher for team 2 somewhere in the map

- order the brawlers to engage the crashers, some will die, some will return barely alive to the repair pad, some will stop and shake, then move, then stop and shake again...
TagsNo tags attached.
Attached Files
20150616_021739_TheColdPlace_98.0.1-785-g09eafe4 develop.sdf (Attachment missing)
20150617_023106_TheColdPlace_98.0.1-808-g73dd62a develop.sdf (Attachment missing)
Checked infolog.txt for Errors

Activities

raaar

2015-06-16 03:27

reporter   ~0014596

possibly related to

https://springrts.com/mantis/view.php?id=4616

Google_Frog

2015-06-16 04:13

reporter   ~0014597

Is the repair pad necessary to replicate the bug?

PepeAmpere

2015-06-16 15:47

reporter   ~0014598

also related to duplicate: https://springrts.com/mantis/view.php?id=4785

which was not possible "reproduce with latest git" :). This thing is fixed and broken randomly in random relases - is possible that jK's git repo is different/not committed.

hokomoko

2015-06-16 23:21

developer   ~0014601

Fix 73dd62a11099a6fd5ceac33efd18765a848a9103 committed to develop branch: Try and fix 0004813, repo: spring changeset id: 5138

hokomoko

2015-06-16 23:23

developer   ~0014602

Google_Frog, can you please test if this solved the parallel flying?

Jools

2015-06-17 00:53

reporter   ~0014603

Try also with latest test xta: here is same thing with xta test-955. There is some weird movement and problems engaging with enemy, but the vibration doesnt happen very often.

In xta, planes have different LOS when flying and when parking on ground, sometimes the "ground los" doesn't update properly to "flying LOS", and I suspected before that engaging problems could be related to that, but I also believe that issue has been fixed. But maybe it's better to test with luaui and possibly luarules disabled to be sure, although if you disable luarules when gunships are parked then they for sure wont update their LOS when lifting.

Jools

2015-06-17 00:54

reporter   ~0014604

http://replays.springrts.com/replay/c5a58055e1a3dbb121ac4425554ef9f7/

hokomoko

2015-06-17 00:55

developer   ~0014605

Last edited: 2015-06-17 00:59

The issues were relevant in xta test-955 as well, it was an engine issue which should be fixed (I hope :) ) in 98.0.1-808-g73dd62a

Your replay is from 98.0 so not very relevant

Jools

2015-06-17 01:08

reporter   ~0014606

Last edited: 2015-06-17 01:26

Here is a replay with xta test-955 and with engine 98.0.1-808-g73dd62a develop

http://replays.springrts.com/replay/97aa8055c1c609b88452a01c7a37712b/

The brawlers all start vibrating a specific distance from air repair pads. Also with luarules and luaui disabled.

Edit: replay desyncs...

hokomoko

2015-06-17 01:22

developer   ~0014607

replay desyncs for me for some reason, can you make a local replay?

Jools

2015-06-17 01:45

reporter   ~0014608

Yes, it desynced for me too, maybe because cheat command was sent to autohost from lobby. I added a new local replay and also the one saved by autohost works now: it's here: http://replays.springrts.com/replay/b9b1805531186234183a70bc8489e3dd/

I tested with both luarules and without them: there are some problems with crashers not targeting some brawlers too, but maybe it's because luarules were disabled, or because of some error in missing unitdef tag.

hokomoko

2015-06-17 01:51

developer   ~0014609

Repair seems buggy as hell, I saw 2 brawlers landing on the same pad :S
I'll take a look.

raaar

2015-06-17 06:48

reporter   ~0014611

multiple aircraft landing on the same pad is another issue

Jools

2015-06-17 11:57

reporter   ~0014613

Up to 2 aircraft have always been able to land on air repair pads in xta, I thought that was a feature. To be honest, nobody uses air repair pads in xta, that's why the bugs go unnoticed.

It's not only xta btw, also in bota and in raaars game I think these things happen.

hokomoko

2015-06-17 13:34

developer   ~0014616

Fix df69e881912c674112c7233f284e3a794b049c3b committed to develop branch: fix 0004616 0004813, repo: spring changeset id: 5140

hokomoko

2015-06-17 13:36

developer   ~0014617

Yes, 2 aircraft seems to be your unit scripts.
Anyway, verify that the vibrating when getting to pad doesn't happen in 98.0.1-810-gdf69e88.

Jools

2015-06-17 15:20

reporter   ~0014620

It seems to be fixed: can't reproduce in 98.0.1-810-gdf69e88.

http://replays.springrts.com/replay/d8728155c1c609b892c8afe260bc1e85/

Issue History

Date Modified Username Field Change
2015-06-16 03:23 raaar New Issue
2015-06-16 03:23 raaar File Added: 20150616_021739_TheColdPlace_98.0.1-785-g09eafe4 develop.sdf
2015-06-16 03:27 raaar Note Added: 0014596
2015-06-16 04:13 Google_Frog Note Added: 0014597
2015-06-16 15:47 PepeAmpere Note Added: 0014598
2015-06-16 23:21 hokomoko Changeset attached => spring develop 73dd62a1
2015-06-16 23:21 hokomoko Note Added: 0014601
2015-06-16 23:21 hokomoko Assigned To => hokomoko
2015-06-16 23:21 hokomoko Status new => resolved
2015-06-16 23:21 hokomoko Resolution open => fixed
2015-06-16 23:23 hokomoko Status resolved => feedback
2015-06-16 23:23 hokomoko Resolution fixed => reopened
2015-06-16 23:23 hokomoko Note Added: 0014602
2015-06-17 00:53 Jools Note Added: 0014603
2015-06-17 00:54 Jools Note Added: 0014604
2015-06-17 00:55 hokomoko Note Added: 0014605
2015-06-17 00:59 hokomoko Note Edited: 0014605
2015-06-17 01:08 Jools Note Added: 0014606
2015-06-17 01:09 Jools Note Edited: 0014606
2015-06-17 01:22 hokomoko Note Added: 0014607
2015-06-17 01:26 Jools Note Edited: 0014606
2015-06-17 01:39 Jools File Added: 20150617_023106_TheColdPlace_98.0.1-808-g73dd62a develop.sdf
2015-06-17 01:45 Jools Note Added: 0014608
2015-06-17 01:51 hokomoko Note Added: 0014609
2015-06-17 06:48 raaar Note Added: 0014611
2015-06-17 06:48 raaar Status feedback => assigned
2015-06-17 11:57 Jools Note Added: 0014613
2015-06-17 13:34 hokomoko Changeset attached => spring develop df69e881
2015-06-17 13:34 hokomoko Note Added: 0014616
2015-06-17 13:34 hokomoko Status assigned => resolved
2015-06-17 13:34 hokomoko Status resolved => feedback
2015-06-17 13:36 hokomoko Note Added: 0014617
2015-06-17 15:20 Jools Note Added: 0014620
2015-06-18 01:07 abma Status feedback => resolved
2015-06-18 01:07 abma Resolution reopened => fixed
2015-06-18 01:07 abma Target Version => 99.0