View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004795 | Spring engine | General | public | 2015-06-04 14:54 | 2015-06-07 16:48 |
| Reporter | jamerlan | Assigned To | hokomoko | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 98.0.1+git | ||||
| Fixed in Version | 98.0.1+git | ||||
| Summary | 0004795: out of LOS color is too bright | ||||
| Description | take a look at attached file (spring99_los.png) In spring 99 with L mode enabled its hard to understand where is "visible" area and where is not. I attached 2 screenshots: for 98 spring(spring98_los.png) and for 99 spring(spring99_los.png). Please make "invisible" area darker | ||||
| Additional Information | BA 8.17 spring commit: commit 47bf190a1801a0490811bfd9c58ba0c4b2ac13b6 Author: jK Date: Thu Jun 4 10:23:46 2015 +0200 fix 0004630: brawler | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
Use (or tell your gamedev to use) Spring.SetLosViewColors properly. I have set up good looking LOS colours for ZK with this. |
|
|
Thanks Google Frog! I created a ticket for BA: http://imolarpg.dyndns.org/trac/balatest/ticket/877 But anyway, are colors on screenshot for spring 99 are engine default? if yes, I still suggest to make "invisible" area darker |
|
|
> Use (or tell your gamedev to use) Spring.SetLosViewColors properly. BA does not use SetLosViewColors. This is (correctly) placed on the engine bugtracker and presumably concerns the engine defaults. |
|
|
Sorry I misworded that. I meant you should either fix your values if you already have some or find some nice values and add a SetLosViewColors widget. Game devs should be responsible for their own LOS colours and a big reason is that people will disagree on what the colours should be. The widget is trivial to write. I thought a bit more though and decent colours are good at least so new game developers have a good impression of the LOS system and don't have to deal with a colour widget early on. So I made a PR for you https://github.com/spring/spring/pull/204 |
|
|
Slightly OT but I suppose it concerns this: is it possible to adjust out-of-los area saturation also with that command? Ie make it black and white or similar? That would be useful... |
|
|
This issue can be marked as RESOLVED because pull request was merged and I tested it, all GOOD |
|
|
https://github.com/spring/spring/commit/65b96279a2df868e0852b6a8839571a58b145c94 Thanks GoogleFrog! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-06-04 14:54 | jamerlan | New Issue | |
| 2015-06-04 14:54 | jamerlan | File Added: spring99_los.png | |
| 2015-06-04 14:54 | jamerlan | File Added: spring98_los.png | |
| 2015-06-04 15:01 | Google_Frog | Note Added: 0014541 | |
| 2015-06-04 15:24 | jamerlan | Note Added: 0014543 | |
| 2015-06-04 18:12 | silentwings | Note Added: 0014545 | |
| 2015-06-04 18:16 | silentwings | Note Edited: 0014545 | |
| 2015-06-04 18:17 | silentwings | Note Edited: 0014545 | |
| 2015-06-04 18:51 | Google_Frog | Note Added: 0014546 | |
| 2015-06-04 20:27 | abma | Relationship added | has duplicate 0004794 |
| 2015-06-05 11:08 | Jools | Note Added: 0014554 | |
| 2015-06-06 18:08 | jamerlan | Note Added: 0014555 | |
| 2015-06-07 16:48 | hokomoko | Note Added: 0014556 | |
| 2015-06-07 16:48 | hokomoko | Status | new => resolved |
| 2015-06-07 16:48 | hokomoko | Fixed in Version | => 98.0.1+git |
| 2015-06-07 16:48 | hokomoko | Resolution | open => fixed |
| 2015-06-07 16:48 | hokomoko | Assigned To | => hokomoko |
