View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004732 | Spring engine | AI | public | 2015-04-08 20:34 | 2015-04-09 11:20 |
| Reporter | UnitedMarsupials | Assigned To | abma | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 98.0 | ||||
| Summary | 0004732: Several silly compiler warnings in tools/pr-downloader/src/lib/minizip/unzip.c | ||||
| Description | /home/ports/games/spring/work/spring_98.0/tools/pr-downloader/src/lib/minizip/unzip.c:1174:24: warning: incompatible pointer types assigning to 'const unsigned long *' from 'const z_crc_t *' (aka 'const unsigned int *') [-Wincompatible-pointer-types] s->pcrc_32_tab = get_crc_table(); ^ ~~~~~~~~~~~~~~~ /home/ports/games/spring/work/spring_98.0/tools/pr-downloader/src/lib/minizip/unzip.c:1246:46: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((pfile_in_zip_read_info->read_buffer == NULL)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/ports/games/spring/work/spring_98.0/tools/pr-downloader/src/lib/minizip/unzip.c:1246:46: note: remove extraneous parentheses around the comparison to silence this warning if ((pfile_in_zip_read_info->read_buffer == NULL)) ~ ^ ~ /home/ports/games/spring/work/spring_98.0/tools/pr-downloader/src/lib/minizip/unzip.c:1246:46: note: use '=' to turn this equality comparison into an assignment if ((pfile_in_zip_read_info->read_buffer == NULL)) ^~ = [ 6%] Building C object rts/lib/headlessStubs/CMakeFiles/headlessStubs.dir/sdlstub.c.o | ||||
| Steps To Reproduce | Compile with clang. | ||||
| Additional Information | The fixes are easy, this ticket is just to raise awareness... | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-04-08 20:34 | UnitedMarsupials | New Issue | |
| 2015-04-09 11:20 | abma | Note Added: 0014318 | |
| 2015-04-09 11:20 | abma | Status | new => resolved |
| 2015-04-09 11:20 | abma | Resolution | open => fixed |
| 2015-04-09 11:20 | abma | Assigned To | => abma |
