View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004509 | Spring engine | General | public | 2014-08-17 07:13 | 2014-08-19 13:38 |
| Reporter | Google_Frog | Assigned To | jK | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 97.0.1+git | ||||
| Target Version | 98.0 | ||||
| Summary | 0004509: 97.0.1-257 Too large path update area for default explosions. | ||||
| Description | Default spring terrain deformation explosions cause large areas of the pathfinder to update. These areas are much larger then the terrain changes. I have used map markers to show the bounds of the update (it can be hard to see from the minimap). The explosion radius is shown as the red circle in the screenshot. It has relevant attributes: areaofeffect=180 craterboost=1 cratermult=3.5 Full definition: https://github.com/ZeroK-RTS/Zero-K/blob/master/weapons/small_buildingex.tdf | ||||
| Steps To Reproduce | Spawn a windmill (armwin). Self destruct it and watch the pathfinder updates in debug mode. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
could it be that mapdeformation takes AoE as radius & dmg code takes it as diameter? |
|
|
No. The function for map deformation that you showed me indicates that deformation matches damage AoE. I also did Spring.GetGroundHeight to test for changes and there were none where I did not expect them to be. |
|
|
hmm, maybe this? https://github.com/spring/spring/blob/develop/rts/Map/BasicMapDamage.cpp#L70 @Google_Frog: which script are you using to draw this? |
|
|
(as we have some performance "problems", this report should be clarified and if needed, fixed => target for 98.0) |
|
|
@Google_Frog: is it fixed? https://github.com/spring/spring/commit/cfab51eae5ac9a8843acd73215430d8f4f376fa1 http://springrts.com/dl/buildbot/default/develop/97.0.1-271-gf10bbb3/win32/ |
|
|
It is much better now. The bounds on the update area appear tighter. There are significantly less pathfinder updates for small explosions (the most common type of explosions). |
|
|
ok, thx for finding this! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-08-17 07:13 | Google_Frog | New Issue | |
| 2014-08-17 07:13 | Google_Frog | File Added: explosionUpdateArea.jpg | |
| 2014-08-17 07:41 | jK | Note Added: 0013523 | |
| 2014-08-17 14:00 | Google_Frog | Note Added: 0013526 | |
| 2014-08-17 22:23 | abma | Note Added: 0013528 | |
| 2014-08-18 14:33 | abma | Note Added: 0013529 | |
| 2014-08-18 14:33 | abma | Target Version | => 98.0 |
| 2014-08-18 22:35 | abma | Note Added: 0013530 | |
| 2014-08-18 22:35 | abma | Assigned To | => abma |
| 2014-08-18 22:35 | abma | Status | new => feedback |
| 2014-08-19 06:49 | Google_Frog | Note Added: 0013532 | |
| 2014-08-19 06:49 | Google_Frog | Status | feedback => assigned |
| 2014-08-19 13:38 | abma | Note Added: 0013535 | |
| 2014-08-19 13:38 | abma | Status | assigned => resolved |
| 2014-08-19 13:38 | abma | Resolution | open => fixed |
| 2014-08-19 13:38 | abma | Assigned To | abma => jK |
