| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004481 | Spring engine | General | public | 2014-07-31 14:33 | 2017-07-15 17:12 | ||||
| Reporter | sprung | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | trivial | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004481: Units don't use moveDef maxSlope when built by mobile cons | ||||||||
| Description | Units don't use their moveDef maxSlope (instead they use the unitDef one which is for buildings) when built by mobile cons instead of from fac. The other buildability tags, {min,max}WaterDepth are correctly obeyed when built by mobiles (read from moveDef, unitDef disregarded). | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
sprung (reporter) 2014-07-31 15:24 |
Update: this commit https://github.com/spring/spring/commit/879816c8acd7f6ff1c996d678cd0d6a6eb0c4e12 made it check maxSlope only for structures (ie. mobiles don't check maxSlope at all). |
|
emmanuel (reporter) 2014-08-05 12:40 |
as i knowed unitdef maxslope is a restriction for being built what make sens for specail gameplay what allow unit to be built only on flat but moving on slopes (seem realistic thought) when movedef is for moving from what i tested it was straight but unsure since i generally use the same values in both {not sure i understood the report well} |
|
Kloot (developer) 2017-07-15 17:12 |
Fix fdafc705fb94248042fefb6eb51c7ca5cc5fdeb9 committed to develop branch: fix 0004481, repo: spring changeset id: 8511 |
| Notes |
| Related Changesets |
|||
|
spring: develop fdafc705
Timestamp: 2017-07-15 17:17:28 Author: Kloot [ Details ] [ Diff ] |
fix 0004481 | ||
| mod - doc/changelog.txt | [ Diff ] [ File ] | ||
| mod - rts/Game/GameHelper.cpp | [ Diff ] [ File ] | ||
| mod - rts/Game/GameHelper.h | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/Unit.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/UnitDef.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/UnitDef.h | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-31 14:33 | sprung | New Issue | |
| 2014-07-31 15:24 | sprung | Note Added: 0013453 | |
| 2014-08-05 12:40 | emmanuel | Note Added: 0013468 | |
| 2017-07-15 17:12 | Kloot | Changeset attached | => spring develop fdafc705 |
| 2017-07-15 17:12 | Kloot | Note Added: 0018042 | |
| 2017-07-15 17:12 | Kloot | Assigned To | => Kloot |
| 2017-07-15 17:12 | Kloot | Status | new => resolved |
| 2017-07-15 17:12 | Kloot | Resolution | open => fixed |
| Issue History |