| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004451 | Spring engine | Lua | public | 2014-06-23 12:03 | 2014-06-24 14:24 | ||||
| Reporter | msafwan | ||||||||
| Assigned To | |||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004451: GameProgress() did not give actual server's gameframe when we start to lag out | ||||||||
| Description | Bug http://springrts.com/mantis/view.php?id=4413 was fixed for rejoining (thanks Cleanrock!), but I found another bug: when we lag out during a game the GameProgress() still did not work. It return the same server's gameframe as Spring.GetGameFrame(). It behave like before the fix for http://springrts.com/mantis/view.php?id=4413 but this time when we lag-out due to slow CPU. This make ZK catch-up bar always show 0-second estimate when we lag out. | ||||||||
| Steps To Reproduce | Its probably reproduce-able by limiting CPU performance in Window's power management (like maximum 50% speed for power saving)and play a really big ZK game, like versus Chicken. | ||||||||
| Additional Information | I got it in: http://zero-k.info/Battles/Detail/271316 Also, can I feature request: that GameProgress() be always called even if we not lagging? (original Spring 91 behaviour) so that a widget can know whether its lagging or not lagging. (if its just silence then widget require dependence on guesses and estimate to make conclusion) | ||||||||
| Tags | luaui | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
msafwan (reporter) 2014-06-23 12:10 Last edited: 2014-06-23 12:19 |
EDIT: this how to reproduce: 1) join a chicken or any big ZK game with Spring 97.0.1-81 2) then, at mid game, where its laggiest, open Power Control panel, and set Maximum processor state to 50% and click apply. 3) ingame open "/info" to see lag counter increase to 20000ms 4) we can see ZK catchup bar appear sometimes, but it show 0-second estimate and quickly close. This mean the GameFrame() did not return correct server's gameFrame. |
|
Kloot (developer) 2014-06-23 13:27 Last edited: 2014-06-23 13:59 |
The way you prove something is with RAW NUMBERS, not with ZK widget behavior examples. Pastebin the output of: function widget:GameProgress(serverGameFrame) print(serverGameFrame, Spring.GetGameFrame()) end "Also, can I feature request: that GameProgress() be always called even if we not lagging?" It IS always called... |
|
msafwan (reporter) 2014-06-24 07:55 Last edited: 2014-06-24 08:06 |
Its hard to find big game to spectate now. The output have not much meaning at all, the function: function widget:GameProgress(serverGameFrame) Spring.Echo(serverGameFrame .. " ".. Spring.GetGameFrame()) end will return serverGameFrame (approximately equal to) == Spring.GetGameFrame() when we lag out. SAMPLE output: [f=0034719] REJOIN TESTER:34800 spGetgameframe: 34719 [f=0035060] REJOIN TESTER:35100 spGetgameframe: 35060 [f=0035381] REJOIN TESTER:35400 spGetgameframe: 35381 [f=0035648] REJOIN TESTER:35700 spGetgameframe: 35648 I have to wait for someone crazy enough to play ZK chicken with Spring 97.0 and survive the lag. Then, I can do test with echo turned on. Despite that, ZK Catchup bar is really reliable widget, it never needed maintenance since it was added in 2012 IMO http://springrts.com/mantis/view.php?id=4413 just fix it for 1 case, and there's this lagging-out case to be handled too. What if other spring feature had same problem...? Similar changes might broke everything else too, except its really hard to check which... (should treat any changes that broke this with prejudice) |
|
cleanrock (reporter) 2014-06-24 13:11 |
Looks good here, i used cpulimit to make me lag and zk lag widget increased from zero. |
|
msafwan (reporter) 2014-06-24 14:21 Last edited: 2014-06-24 14:22 |
cleanrock is right, GameProgress() appear to work :) (sorry for saying bad thing about Spring 97 and regretted for being wrong. But I did go test it too, but turn out it seem to be working, thanks:) http://i515.photobucket.com/albums/t355/xponen/Spring97-81gameProgresstest.jpg ) So ... um, can pls close report :P |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-23 12:03 | msafwan | New Issue | |
| 2014-06-23 12:05 | msafwan | Tag Attached: luaui | |
| 2014-06-23 12:10 | msafwan | Note Added: 0013321 | |
| 2014-06-23 12:19 | msafwan | Note Edited: 0013321 | View Revisions |
| 2014-06-23 13:27 | Kloot | Note Added: 0013322 | |
| 2014-06-23 13:59 | Kloot | Note Edited: 0013322 | View Revisions |
| 2014-06-24 07:55 | msafwan | Note Added: 0013342 | |
| 2014-06-24 08:03 | msafwan | Note Edited: 0013342 | View Revisions |
| 2014-06-24 08:04 | msafwan | Note Edited: 0013342 | View Revisions |
| 2014-06-24 08:06 | msafwan | Note Edited: 0013342 | View Revisions |
| 2014-06-24 13:11 | cleanrock | Note Added: 0013343 | |
| 2014-06-24 14:21 | msafwan | Note Added: 0013344 | |
| 2014-06-24 14:22 | msafwan | Note Edited: 0013344 | View Revisions |
| 2014-06-24 14:22 | msafwan | Note Edited: 0013344 | View Revisions |
| 2014-06-24 14:24 | cleanrock | Status | new => closed |
| 2014-06-24 14:24 | cleanrock | Resolution | open => no change required |
| Issue History |