| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004448 | Spring engine | General | public | 2014-06-19 14:33 | 2014-06-21 16:45 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | cleanrock | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | 98.0 | Fixed in Version | |||||||
| Summary | 0004448: Constructors no longer fire while building | ||||||||
| Description | This is a game design decision. This change breaks my game. "Better yet they should fire while doing everything and the game designer can decide if firing should be blocked within the unit script. That is assuming there are easy callins for actions such as reclaiming." ~ GoogleFrog http://springrts.com/mantis/view.php?id=2420 Make nothing block firing and then let the game creators return false in AimWeapon. It is much much easier for a game creator to stop a unit from firing than it is to hack in some firing behaviour. Stopping firing is a simple script change, adding firing involves rewriting all the engine behaviour or adding fake units. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
cleanrock (reporter) 2014-06-19 14:41 Last edited: 2014-06-19 14:41 |
@spring_devs, Can we remove calls to TempHoldFire completely and let games handle blocking fire if they want ? Imo, the current behaviour after my commit is better(more consistent) than it was before but if we can let games decide this its even better. |
|
Kloot (developer) 2014-06-19 23:10 |
"assuming there are easy callins for actions such as reclaiming" No. The best solution would therefore be to add an AllowBuilderHoldFire(action) Lua callin and make TempHoldFire defer to that. In the meantime, consistency > inconvience. |
|
FLOZi (reporter) 2014-06-20 00:41 |
StartBuilding and check current active order. Being consistently convenient is better than consistently inconvenient. |
|
Kloot (developer) 2014-06-20 02:06 |
"StartBuilding and check current active order." 1) doesn't prevent the engine from letting builders try to attack anyway --> inelegant 2) forces "block all weapons" boilerplate crap to be added in every constructor script 3) changes existing expected behavior by removing the TempHoldFire's |
|
KingRaptor (reporter) 2014-06-21 04:58 |
Would a modrules tag for "allow shooting while building" be sufficient? |
|
abma (administrator) 2014-06-21 06:47 Last edited: 2014-06-21 06:50 |
can this be controlled inside the callin AllowWeaponTarget? if so, tempholdfire could be removed?! |
|
silentwings (reporter) 2014-06-21 10:52 Last edited: 2014-06-21 10:54 |
I am with KR here - if this has to be implemented the cleanest way is with a unitdef tag. I can't see much scope for wanting to change "does constructor fire while building/etc" on the fly. |
|
cleanrock (reporter) 2014-06-21 11:27 |
https://github.com/spring/spring/commit/5a82d75 I don't want to set this ticket fixed until possible corrections are done. |
|
cleanrock (reporter) 2014-06-21 16:43 |
Should be fixed now. Kloot added performance optimizations in https://github.com/spring/spring/commit/283af7b |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-19 14:33 | Google_Frog | New Issue | |
| 2014-06-19 14:41 | cleanrock | Note Added: 0013302 | |
| 2014-06-19 14:41 | cleanrock | Note Edited: 0013302 | View Revisions |
| 2014-06-19 20:46 | abma | Relationship added | related to 0002420 |
| 2014-06-19 23:10 | Kloot | Note Added: 0013305 | |
| 2014-06-20 00:41 | FLOZi | Note Added: 0013306 | |
| 2014-06-20 02:06 | Kloot | Note Added: 0013307 | |
| 2014-06-21 04:58 | KingRaptor | Note Added: 0013308 | |
| 2014-06-21 06:42 | abma | Target Version | => 98.0 |
| 2014-06-21 06:47 | abma | Note Added: 0013309 | |
| 2014-06-21 06:47 | abma | Note Edited: 0013309 | View Revisions |
| 2014-06-21 06:47 | abma | Note Edited: 0013309 | View Revisions |
| 2014-06-21 06:49 | abma | Note Edited: 0013309 | View Revisions |
| 2014-06-21 06:50 | abma | Note Edited: 0013309 | View Revisions |
| 2014-06-21 10:52 | silentwings | Note Added: 0013310 | |
| 2014-06-21 10:54 | silentwings | Note Edited: 0013310 | View Revisions |
| 2014-06-21 11:27 | cleanrock | Note Added: 0013311 | |
| 2014-06-21 16:43 | cleanrock | Note Added: 0013313 | |
| 2014-06-21 16:43 | cleanrock | Status | new => closed |
| 2014-06-21 16:43 | cleanrock | Assigned To | => cleanrock |
| 2014-06-21 16:43 | cleanrock | Resolution | open => fixed |
| 2014-06-21 16:44 | cleanrock | Status | closed => feedback |
| 2014-06-21 16:44 | cleanrock | Resolution | fixed => reopened |
| 2014-06-21 16:45 | cleanrock | Status | feedback => resolved |
| 2014-06-21 16:45 | cleanrock | Resolution | reopened => fixed |
| Issue History |