View Issue Details

IDProjectCategoryView StatusLast Update
0004381Spring engineGeneralpublic2019-08-22 00:21
ReporterFloris Assigned ToKloot  
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version104.0 +git 
Summary0004381: Allow to cancel selection rectangle with ESC/custom action
DescriptionWhen you are selecting you cant cancel it with the escape key.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Google_Frog

2014-05-06 08:51

reporter   ~0013038

So? I would not want to be able to cancel selecting with Esc.

Jools

2014-05-07 02:02

reporter   ~0013039

But many do, it's the main function of that key. But you can accomplish the same thing with a widget, return true from a keypress with ESC. But you can only have one such widget as it traps the call.

Still, I agree this should be standard behaviour, you can also lua righ click and Z to cancel selecting, but few want that.

abma

2014-05-07 06:34

administrator   ~0013040

canceling selection with ESC seems common in desktop environments. Works on Windows and Gnome at least.

Jools

2014-05-07 15:32

reporter   ~0013041

Just this code:
function widget:KeyPress(key, mods, isRepeat)
if (key == 0x01B) and (not isRepeat) and (not mods.ctrl) and (not mods.shift) and enableESC then -- KEY = ESC
            SendCommands("deselect")
            return true end

Google_Frog

2014-05-07 17:19

reporter   ~0013042

I am not against giving us the ability to cancel selection dragging with ESC. I just don't want it to be hardcoded in and impossible to customize.

A good implementation of this feature would use the current hotkey and action system. Add an action such as 'cancelselectbox' and it is then hotkeyable and able to be called by lua.

silentwings

2014-05-12 03:37

reporter   ~0013052

Last edited: 2014-05-12 03:38

+1 to what GF said, afaik its already possible to do this & no need for any change to engine

Floris

2014-05-12 13:07

reporter   ~0013053

... and so nothing will happen.


Common default behavior should be the default. Rather have an opt-out, than opt-in.

Jools

2014-05-12 16:37

reporter   ~0013054

+1 to what Floris said. And the lua option has limitations, you can only use that code in one widget.

Kloot

2019-08-22 00:21

developer   ~0020089

/mousecancelselectionrectangle

Issue History

Date Modified Username Field Change
2014-05-06 01:33 Floris New Issue
2014-05-06 08:51 Google_Frog Note Added: 0013038
2014-05-07 02:02 Jools Note Added: 0013039
2014-05-07 06:34 abma Note Added: 0013040
2014-05-07 06:34 abma Priority low => normal
2014-05-07 06:34 abma Severity minor => feature
2014-05-07 15:32 Jools Note Added: 0013041
2014-05-07 17:19 Google_Frog Note Added: 0013042
2014-05-08 19:06 abma Summary ESC wont cancel making a selection rectangle => Allow to cansel selection rectangle with ESC/custom command
2014-05-08 19:07 abma Summary Allow to cansel selection rectangle with ESC/custom command => Allow to cansel selection rectangle with ESC/custom action
2014-05-11 23:30 abma Summary Allow to cansel selection rectangle with ESC/custom action => Allow to cancel selection rectangle with ESC/custom action
2014-05-12 03:37 silentwings Note Added: 0013052
2014-05-12 03:38 silentwings Note Edited: 0013052
2014-05-12 03:38 silentwings Note Edited: 0013052
2014-05-12 13:07 Floris Note Added: 0013053
2014-05-12 16:37 Jools Note Added: 0013054
2019-08-22 00:21 Kloot Assigned To => Kloot
2019-08-22 00:21 Kloot Status new => resolved
2019-08-22 00:21 Kloot Resolution open => fixed
2019-08-22 00:21 Kloot Fixed in Version => 104.0 +git
2019-08-22 00:21 Kloot Note Added: 0020089