| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004373 | Spring engine | General | public | 2014-04-29 20:40 | 2014-05-25 23:49 | ||||
| Reporter | silentwings | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 96.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004373: Spring.AssignPlayerToTeam | ||||||||
| Description | I made a Spring.AssignPlayerToTeam(playerID, teamID) that does what it says. See most recent commits on https://github.com/silentwings/spring I *think* it's sync (note my first attempt wasn't, hence second commit) but I dont know a watertight way of checking. This was requested on http://springrts.com/phpbb/viewtopic.php?f=1&t=32081&p=557326#p557279, I just made it for fun. | ||||||||
| Additional Information | I find github very _wtf_ so if you want to merge it and I need to do something then you'll have to tell me what. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
silentwings (reporter) 2014-04-29 20:40 |
should have read "think it's sync-safe" |
|
silentwings (reporter) 2014-05-13 13:17 |
Could someone look at/commit this please? |
|
MajorBoredom (reporter) 2014-05-13 20:10 |
If you are new to using github to do feature branches / pull requests I can help you out a bit with the syntax. Talk to abma or jK about merging when you are ready to have your changes integrated. |
|
silentwings (reporter) 2014-05-14 00:56 Last edited: 2014-05-14 00:57 |
The change is ready to be integrated and is already on github, on the link give above (although I may be glad of your help in future :p) |
|
abma (administrator) 2014-05-14 01:06 |
you should send a pull request then... |
|
abma (administrator) 2014-05-14 01:09 |
note: its pretty unclear that a "feature request" contains a patch. so please send a pull request as it allows easier to see a diff / give comments to specific lines. thanks! |
|
silentwings (reporter) 2014-05-14 02:50 |
I had no idea that I had the option to send a pull request. But I figured it out and its here https://github.com/spring/spring/pull/99. For some reason it also included two earlier commits, the second of which reverts the first, so they have no effect. |
|
silentwings (reporter) 2014-05-25 23:18 |
Could this have a response please? I was hoping to have it in 97.0. |
|
abma (administrator) 2014-05-25 23:45 |
awww... just merging it into develop atm |
|
abma (administrator) 2014-05-25 23:49 |
0004014 is a candidate for 98.0, too... so no worries i don't want to wait long for 98.0. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-04-29 20:40 | silentwings | New Issue | |
| 2014-04-29 20:40 | silentwings | Note Added: 0013030 | |
| 2014-05-13 13:17 | silentwings | Note Added: 0013073 | |
| 2014-05-13 20:10 | MajorBoredom | Note Added: 0013081 | |
| 2014-05-14 00:56 | silentwings | Note Added: 0013086 | |
| 2014-05-14 00:57 | silentwings | Note Edited: 0013086 | View Revisions |
| 2014-05-14 01:06 | abma | Note Added: 0013087 | |
| 2014-05-14 01:09 | abma | Note Added: 0013088 | |
| 2014-05-14 02:50 | silentwings | Note Added: 0013092 | |
| 2014-05-25 23:18 | silentwings | Note Added: 0013152 | |
| 2014-05-25 23:43 | Kloot | Assigned To | => Kloot |
| 2014-05-25 23:43 | Kloot | Status | new => assigned |
| 2014-05-25 23:45 | abma | Note Added: 0013153 | |
| 2014-05-25 23:49 | abma | Note Added: 0013154 | |
| 2014-05-25 23:49 | abma | Status | assigned => resolved |
| 2014-05-25 23:49 | abma | Resolution | open => fixed |
| Issue History |