| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004330 | Spring engine | General | public | 2014-03-12 21:57 | 2014-03-18 22:46 | ||||
| Reporter | Beherith | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 96.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004330: 96.0.1-340 gadget:DrawUnit() does not get called | ||||||||
| Description | It got called in 96.0, and in latest engine, it does not get called. | ||||||||
| Steps To Reproduce | Happens with both BA:R and BA. | ||||||||
| Additional Information | It does not even get called in gadgets.lua: function gadgetHandler:DrawUnit(unitID, drawMode) Spring.Echo('registering drawunit globally') for index,g in ipairs(self.DrawUnitList) do Spring.Echo('registering drawunit for',index) if (g:DrawUnit(unitID, drawMode)) then return true end end return false end | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2014-03-13 11:22 |
missing Spring.UnitRendering.SetUnitLuaDraw ? |
|
Beherith (reporter) 2014-03-13 23:42 |
http://imolarpg.dyndns.org/trac/balatest/browser/branches/BAR/luarules/gadgets/gfx_customUnitShaders.lua#L398 That is set in the UnitFinished callin, and I checked that is indeed executed. |
|
cleanrock (reporter) 2014-03-15 08:43 |
This stopped working with luasynced_split, bisect result: The first bad commit could be any of: 1d60e5f7282c94403275144b580978d105068e56 0eac9f5f9b3b0783290b0c1982a355f36ab1e919 cd4120c5075b5b3611f5e539ce49ec42999f9c02 33e01d249c0d4faaec4e26228d4605b65f997b88 We cannot bisect more! |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-03-12 21:57 | Beherith | New Issue | |
| 2014-03-13 11:22 | jK | Note Added: 0012928 | |
| 2014-03-13 17:04 | abma | Status | new => feedback |
| 2014-03-13 23:42 | Beherith | Note Added: 0012933 | |
| 2014-03-13 23:42 | Beherith | Status | feedback => new |
| 2014-03-15 08:43 | cleanrock | Note Added: 0012941 | |
| 2014-03-15 15:25 | jK | Assigned To | => jK |
| 2014-03-15 15:25 | jK | Status | new => assigned |
| 2014-03-18 22:46 | jK | Changeset attached | => spring develop 7a95d378 |
| 2014-03-18 22:46 | jK | Status | assigned => resolved |
| 2014-03-18 22:46 | jK | Resolution | open => fixed |
| Issue History |