View Issue Details

IDProjectCategoryView StatusLast Update
0004286Spring engineGeneralpublic2014-01-21 06:42
Reporterabma Assigned TojK  
PriorityhighSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version96.0.1+git 
Target Version97.0 
Summary0004286: unclear return type of MouseRelease
Descriptiondocs say its a bool:

http://springrts.com/wiki/LuaCallinReturn

code says its a int:

https://github.com/spring/spring/blob/develop/rts/Lua/LuaHandle.cpp#L1932
int MouseRelease(int x, int y, int button); // return a cmd index, or -1

TODO says it should be a bool / void:

https://github.com/spring/spring/blob/develop/rts/System/EventClient.cpp#L155
int CEventClient::MouseRelease(int x, int y, int button) { return -1; } // FIXME - bool / void?
Additional Informationwhat is cmd index?
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2014-01-21 00:45

administrator   ~0012750

imo it should be bool as existing lua code returns bool and the value imo would make more sense.

(=event is handled or not)

abma

2014-01-21 00:45

administrator   ~0012751

whats correct?

Issue History

Date Modified Username Field Change
2014-01-21 00:44 abma New Issue
2014-01-21 00:45 abma Note Added: 0012750
2014-01-21 00:45 abma Assigned To => abma
2014-01-21 00:45 abma Status new => assigned
2014-01-21 00:45 abma Note Added: 0012751
2014-01-21 00:45 abma Assigned To abma => jK
2014-01-21 00:45 abma Status assigned => feedback
2014-01-21 00:47 abma Priority normal => high
2014-01-21 02:06 abma Description Updated
2014-01-21 06:42 jK Changeset attached => spring develop 4c104344
2014-01-21 06:42 jK Status feedback => resolved
2014-01-21 06:42 jK Resolution open => fixed