2025-07-20 08:55 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004040Spring engineGeneralpublic2013-10-08 22:11
Reporterabma 
Assigned ToKloot 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version94.1.1+git 
Target Version95.0Fixed in Version 
Summary0004040: test.lua broken / Spring.GetTimer() (?)
Description[f=0015030] Realtime 0s gametime: 501s


Realtime should be something like 120 seconds.

http://buildbot.springrts.com/builders/validationtests/builds/3666/steps/validation%20test/logs/stdio

output in test.lua is made here:
https://github.com/spring/spring/blob/develop/test/validation/LuaUI/Widgets/test.lua#L26
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
related to 0004025closedKloot Spring.DIffTimers always returns 0 
related to 0004041resolvedKloot buildslaves/validation test fail 
related to 0003962resolvedKloot loadscreen is not picked randomly 
+Relationships

-Notes

~0011722

Kloot (developer)

What does the widget from 0004025 output for you?

FYI it works fine here:

[f=0036000] Realtime 17s gametime: 1200s
[f=0036000] Run at 66.88x real time

~0011723

abma (administrator)

Last edited: 2013-10-08 14:35

View 2 revisions

always 0:

[f=0000253] 0


maybe related to debug build? validation test builds debug as well...

Spring 94.1.1-1293-gc6f5bcc develop (Debug)

if its chrono: boost-105300 used here, boost-105000 for validation test
(=1.53 and 1.50)

~0011724

abma (administrator)

Last edited: 2013-10-08 14:53

View 3 revisions

awww, wrong, was to impatient:


[f=0001357] 0
[f=0001358] 131.07200622559
[...]
[f=0005481] 131.07200622559
[f=0005481] 262.14401245117
[...]
[f=0009604] 262.14401245117
[f=0009605] 393.21600341797
[...]
[f=0013727] 393.21600341797
[f=0013728] 524.28802490234


speed was set to 1.

some rounding issue? lua normally uses double for numbers, for spring we use floats because of streflop. validation buildslave is 64 bit / my os is 64 bit as well. gcc-4.7.2 on buildslave, gcc is 4.8.1 here

~0011725

abma (administrator)

https://github.com/spring/spring/commit/4f102cd934eaa9c8ba77522844f106efffe6194f

has the issue fixed for me, waiting for the buildslave...

~0011726

Kloot (developer)

Last edited: 2013-10-08 15:03

View 2 revisions

It might be that gettime() starts out too large (depending on the epoch chrono uses) for floats to represent precisely.

Does 4f102cd934 behave any better?

e: ok, good to know

+Notes

-Issue History
Date Modified Username Field Change
2013-10-08 05:50 abma New Issue
2013-10-08 06:30 abma Relationship added related to 0004041
2013-10-08 12:52 Kloot Relationship added related to 0004025
2013-10-08 12:56 Kloot Note Added: 0011722
2013-10-08 14:33 abma Note Added: 0011723
2013-10-08 14:35 abma Note Edited: 0011723 View Revisions
2013-10-08 14:49 abma Note Added: 0011724
2013-10-08 14:51 abma Note Edited: 0011724 View Revisions
2013-10-08 14:53 abma Note Edited: 0011724 View Revisions
2013-10-08 15:02 abma Note Added: 0011725
2013-10-08 15:03 Kloot Note Added: 0011726
2013-10-08 15:03 Kloot Note Edited: 0011726 View Revisions
2013-10-08 15:05 abma Status new => resolved
2013-10-08 15:05 abma Resolution open => fixed
2013-10-08 15:05 abma Assigned To => Kloot
2013-10-08 22:11 abma Relationship added related to 0003962
+Issue History