View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004009Spring engineGeneralpublic2013-09-18 12:312013-09-18 21:17
Reportersilentwings Assigned Toabma  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version94.1.1+git 
Summary0004009: "Player XX has resigned and is now spectating" messages still appear
Descriptiontested with 94.1.1-1166
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2013-09-18 19:47

administrator   ~0011630

yes, but this is only print to console/infolog.txt ?!

https://github.com/spring/spring/blob/develop/rts/Net/NetCommands.cpp#L928

silentwings

2013-09-18 20:07

reporter   ~0011631

Last edited: 2013-09-18 20:10

 Yes, but it means that if i want to (fully) reimplement death messages in lua then I've got to filter them out of the chat console.

Since (with BA, at least) some ppl use their own ui/consoles the only way to reliably filter would be for me to do the filtering in the widget/gadget handlers, which would be pretty hacky.

abma

2013-09-18 20:12

administrator   ~0011632

they appear in the chat console? urgs.. then i didn't find the line of code yet...

silentwings

2013-09-18 21:16

reporter   ~0011634

There are AI ones as well - but I think those have to be left as engine messages for now, unless you're going to write a new callin, since I don't think lua can always spot when an AI starts/dies.

Issue History

Date Modified Username Field Change
2013-09-18 12:31 silentwings New Issue
2013-09-18 19:47 abma Note Added: 0011630
2013-09-18 20:07 silentwings Note Added: 0011631
2013-09-18 20:10 silentwings Note Edited: 0011631
2013-09-18 20:10 silentwings Note Edited: 0011631
2013-09-18 20:12 abma Note Added: 0011632
2013-09-18 21:16 silentwings Note Added: 0011634
2013-09-18 21:17 abma Changeset attached => spring develop 48bb4788
2013-09-18 21:17 abma Assigned To => abma
2013-09-18 21:17 abma Status new => resolved
2013-09-18 21:17 abma Resolution open => fixed