| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004009 | Spring engine | General | public | 2013-09-18 12:31 | 2013-09-18 21:17 | ||||
| Reporter | silentwings | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 94.1.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004009: "Player XX has resigned and is now spectating" messages still appear | ||||||||
| Description | tested with 94.1.1-1166 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2013-09-18 19:47 |
yes, but this is only print to console/infolog.txt ?! https://github.com/spring/spring/blob/develop/rts/Net/NetCommands.cpp#L928 |
|
silentwings (reporter) 2013-09-18 20:07 Last edited: 2013-09-18 20:10 |
Yes, but it means that if i want to (fully) reimplement death messages in lua then I've got to filter them out of the chat console. Since (with BA, at least) some ppl use their own ui/consoles the only way to reliably filter would be for me to do the filtering in the widget/gadget handlers, which would be pretty hacky. |
|
abma (administrator) 2013-09-18 20:12 |
they appear in the chat console? urgs.. then i didn't find the line of code yet... |
|
silentwings (reporter) 2013-09-18 21:16 |
There are AI ones as well - but I think those have to be left as engine messages for now, unless you're going to write a new callin, since I don't think lua can always spot when an AI starts/dies. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-09-18 12:31 | silentwings | New Issue | |
| 2013-09-18 19:47 | abma | Note Added: 0011630 | |
| 2013-09-18 20:07 | silentwings | Note Added: 0011631 | |
| 2013-09-18 20:10 | silentwings | Note Edited: 0011631 | View Revisions |
| 2013-09-18 20:10 | silentwings | Note Edited: 0011631 | View Revisions |
| 2013-09-18 20:12 | abma | Note Added: 0011632 | |
| 2013-09-18 21:16 | silentwings | Note Added: 0011634 | |
| 2013-09-18 21:17 | abma | Changeset attached | => spring develop 48bb4788 |
| 2013-09-18 21:17 | abma | Assigned To | => abma |
| 2013-09-18 21:17 | abma | Status | new => resolved |
| 2013-09-18 21:17 | abma | Resolution | open => fixed |
| Issue History |