| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004002 | Spring engine | General | public | 2013-09-12 10:04 | 2013-09-16 02:03 | ||||
| Reporter | silentwings | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 94.1.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004002: way to disable all team/player died messages | ||||||||
| Description | I'd like a way to turn off all the engines team/player died messages and then I'll reimplement them in a gadget Using messages.lua and attempting to replace with "" or " " has no effect (although it can replace some with non-empty strings). I'm wanting to do this because messages.lua seems not to affect the 'player died' messages at all (see below), and because I've got gadgetry that handles reonnecting/afk/unit-less players -> the result is that the engine isn't necessarily aware when teams/players lose all their units. In general my feeling is that death messages would be better off in gadgetry anyway! | ||||||||
| Additional Information | Using messages.lua I can replace the "Team %i is no more" and "Team %i (%s) has been obliterated" death messages, but it seems to have no effect on the "Player %i (%s) resigned and is now spectating!" In the first case, using %s for playername in the replaced message results in a string containing junk (it works in other two). | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
silentwings (reporter) 2013-09-12 10:15 |
"Team %i (%s) has been obliterated" should have read "Team %i (lead by %s) is no more" (copy-pasted wrong line from my messages.lua) |
|
abma (administrator) 2013-09-16 00:13 Last edited: 2013-09-16 00:15 |
https://github.com/spring/spring/blob/develop/rts/Sim/Misc/Team.cpp#L239 & https://github.com/spring/spring/blob/develop/rts/Game/Messages.cpp#L36 imo this code should be replaced by lua. CMessages::Tr seems to be only used in Team.cpp. hmm... why does this c++ code exists at all? :-| http://springrts.com/wiki/LuaCallinReturn -> TeamDied |
|
silentwings (reporter) 2013-09-16 00:31 |
As well as TeamDied, would be good to also have a callin for PlayerResigns (playerchanged is not ideal to use for this since you then have to track in lua of who is alive/dead). |
|
FLOZi (reporter) 2013-09-16 00:37 |
+1 for messages.lua meeting a long overdue demise. |
|
Kloot (developer) 2013-09-16 00:53 |
"why does this c++ code exists at all?" Because messages.lua used to be messages.tdf and the code parsing it predates all of Lua (https://github.com/spring/spring/commit/4bd089aeb1a5496400810c19d23e86cec1740de8). IMO it can go. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-09-12 10:04 | silentwings | New Issue | |
| 2013-09-12 10:15 | silentwings | Note Added: 0011593 | |
| 2013-09-16 00:13 | abma | Note Added: 0011619 | |
| 2013-09-16 00:15 | abma | Note Edited: 0011619 | View Revisions |
| 2013-09-16 00:31 | silentwings | Note Added: 0011620 | |
| 2013-09-16 00:37 | FLOZi | Note Added: 0011621 | |
| 2013-09-16 00:53 | Kloot | Note Added: 0011622 | |
| 2013-09-16 02:03 | abma | Changeset attached | => spring develop 599e3926 |
| 2013-09-16 02:03 | abma | Assigned To | => abma |
| 2013-09-16 02:03 | abma | Status | new => resolved |
| 2013-09-16 02:03 | abma | Resolution | open => fixed |
| Issue History |