|
|
| Reporter | FLOZi | |
|---|
| Assigned To | Kloot | |
|---|
| Priority | low | Severity | trivial | Reproducibility | always |
|---|
| Status | resolved | Resolution | fixed | |
|---|
| Product Version | | |
|---|
| Target Version | | Fixed in Version | 94.1.1+git | |
|---|
|
|
| Summary | 0003961: Armordefs.lua requires a key-value map rather than array, but the value isn't used |
|---|
| Description | When armor.txt was introduced, the engine tdf parser required that each key had a value, so they were filled with junk and ignored.
When trepan came along and lua-ised armor.txt into armordefs.lua, he was unaware that the values were junk, so he kept the key-value map instead of using a straightforward array.
https://github.com/spring/spring/blob/94.1/rts/Sim/Misc/DamageArrayHandler.cpp#L54
This requires that games either have defs with the junk in them or an extra snippet to convert: http://springrts.com/wiki/Armordefs.lua#Example
It'd be nice if this historical error was finally corrected. |
|---|
| Additional Information | WRT backwards compatibility, the base content armordefs.lua could be modified such that games using armor.txt need not be modified. Those using their own armordefs.lua will in most (all?) cases merely need to remove the extra snippet of code. |
|---|
| Tags | No tags attached. |
|---|
|
|
| Checked infolog.txt for Errors | |
|---|
|
|
| Attached Files |
|
|---|
Relationships 
Relationships