2025-07-24 22:37 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003765Spring engineGeneralpublic2013-08-10 17:11
Reportersprung 
Assigned ToKloot 
PrioritylowSeveritytrivialReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0003765: Default feature team -1 is inaccessible
DescriptionPre-placed features belong to team -1; however, it's not possible to add new features to this team through Spring.TransferFeature as the call requires the team argument to be >= 0. Responsible for that is https://github.com/spring/spring/blob/develop/rts/Lua/LuaSyncedCtrl.cpp#L2488 . It could be changed to
if (!teamHandler->IsValidTeam(teamId) && (teamId != -1)) {
since CFeature::ChangeTeam ( https://github.com/spring/spring/blob/develop/rts/Sim/Features/Feature.cpp#L118 ) already seems to expect negative arguments. However, it redirects negative team change requests to team 0 (which is a player), so it should be changed to team -1 (as supported by a comment there).
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
related to 0003871resolvedKloot "/give treetype1" -1 not possible 
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2013-05-01 00:27 sprung New Issue
2013-06-25 19:25 abma Relationship added related to 0003871
2013-08-10 17:11 Kloot Changeset attached => spring develop 82cda1ab
2013-08-10 17:11 Kloot Assigned To => Kloot
2013-08-10 17:11 Kloot Status new => resolved
2013-08-10 17:11 Kloot Resolution open => fixed
+Issue History