View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003765 | Spring engine | General | public | 2013-05-01 00:27 | 2013-08-10 17:11 |
| Reporter | sprung | Assigned To | Kloot | ||
| Priority | low | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0003765: Default feature team -1 is inaccessible | ||||
| Description | Pre-placed features belong to team -1; however, it's not possible to add new features to this team through Spring.TransferFeature as the call requires the team argument to be >= 0. Responsible for that is https://github.com/spring/spring/blob/develop/rts/Lua/LuaSyncedCtrl.cpp#L2488 . It could be changed to if (!teamHandler->IsValidTeam(teamId) && (teamId != -1)) { since CFeature::ChangeTeam ( https://github.com/spring/spring/blob/develop/rts/Sim/Features/Feature.cpp#L118 ) already seems to expect negative arguments. However, it redirects negative team change requests to team 0 (which is a player), so it should be changed to team -1 (as supported by a comment there). | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-05-01 00:27 | sprung | New Issue | |
| 2013-06-25 19:25 | abma | Relationship added | related to 0003871 |
| 2013-08-10 17:11 | Kloot | Changeset attached | => spring develop 82cda1ab |
| 2013-08-10 17:11 | Kloot | Assigned To | => Kloot |
| 2013-08-10 17:11 | Kloot | Status | new => resolved |
| 2013-08-10 17:11 | Kloot | Resolution | open => fixed |
