View Issue Details

IDProjectCategoryView StatusLast Update
0003646Spring engineGeneralpublic2013-03-30 15:26
ReporterjK Assigned TojK  
PrioritynormalSeveritytweakReproducibilityhave not tried
Status resolvedResolutionfixed 
Summary0003646: change PortableMode trigger
DescriptionI want to trigger portable mode when springsettings.cfg resides next to spring binary.
Cause atm PortableMode is always true for windows systems (spring.exe & unitsync.dll are next to each other). But I want to change the DataDir priority there to:
...
HomeDirs
InstallDir
...

so settings are saved by default in "My Games/".
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2013-03-26 19:48

administrator   ~0010271

-> springsettings.cfg is in "My Games", too?

jK

2013-03-26 19:55

developer   ~0010272

Spring already uses MyGames as writedir if it doesn't got write-access to the InstallDir (90% the case for windows users). But if it got write-access to the installdir (on windows) it _always_ uses it as writedir cause it assumes it is in portable mode (spring.exe & unitsync.dll are next to each other).
This was the preferred method 5years ago when WinVista was new. Now all users got used to games that install their settings to MyGames. So when you install Spring to ProgramFiles it shouldn't use the dir as writedir just cause you are lazy & not paranoid and always login with root/admin rights.

abma

2013-03-26 20:01

administrator   ~0010273

Last edited: 2013-03-26 20:02

can't we make it configurable at compile time?

so for win32 it would be something like this:

SPRING_DATADIR='%ENV%;%APPDATA%\Spring;%PERSONAL%\My Games\Spring;...'

(escaping is done at run-time)

only requirement would be to create an own escaping function for %PERSONAL% (and other folders if needed)

abma

2013-03-26 20:03

administrator   ~0010274

Last edited: 2013-03-26 20:03

still +1 for any change, it can't get worse as it is ;)

jK

2013-03-26 20:05

developer   ~0010275

Last edited: 2013-03-26 20:07

No special rules imo.
The hierarchy should similar/equal on all platforms and splitted in levels (to easy remember).

-> compile defines should just contain distro relevant paths (/usr/share vs. /usr/games/share etc.)

FLOZi

2013-03-26 22:16

reporter   ~0010278

"Now all users got used to games that install their settings to MyGames."

Speak for yourself. If this must change, please ensure we can continue to have everything in one place.

Forboding Angel

2013-03-26 23:54

reporter   ~0010281

I thought that this was the way it worked already O_O

Holy... That explains so much...

jK

2013-03-27 00:15

developer   ~0010283

"If this must change, please ensure we can continue to have everything in one place."
I don't want to remove portable mode I just don't want it always default enabled on windows.

jK

2013-03-27 20:50

developer   ~0010295

Last edited: 2013-03-27 20:52

question1:
/home/USER/.springrc
/home/USER/.spring/springrc
/home/USER/.config/spring/springrc
?

question2:
always springrc hidden?

question3:
use and prefer springsettings.cfg under linux, too?

Forboding Angel

2013-03-27 20:52

reporter   ~0010296

@Q1
Imo it belongs in .spring

@Q2
I don't really see the need for it to be hidden and always thought that that was an odd choice

@Q3
Imo yes, it would make the Linux <-> Windows much more uniform. Also, to any non-dev, springrc is a meaningless filename, whereas springsettings.cfg is pretty self-explanatory

jK

2013-03-30 15:26

developer   ~0010324

http://springrts.com/phpbb/viewtopic.php?f=12&t=30044&p=538808#p538808

Issue History

Date Modified Username Field Change
2013-03-26 19:17 jK New Issue
2013-03-26 19:48 abma Note Added: 0010271
2013-03-26 19:55 jK Note Added: 0010272
2013-03-26 20:01 abma Note Added: 0010273
2013-03-26 20:02 abma Note Edited: 0010273
2013-03-26 20:03 abma Note Added: 0010274
2013-03-26 20:03 abma Note Edited: 0010274
2013-03-26 20:05 jK Note Added: 0010275
2013-03-26 20:07 jK Note Edited: 0010275
2013-03-26 22:16 FLOZi Note Added: 0010278
2013-03-26 23:54 Forboding Angel Note Added: 0010281
2013-03-27 00:15 jK Note Added: 0010283
2013-03-27 20:50 jK Note Added: 0010295
2013-03-27 20:52 jK Note Edited: 0010295
2013-03-27 20:52 Forboding Angel Note Added: 0010296
2013-03-30 15:26 jK Note Added: 0010324
2013-03-30 15:26 jK Status new => resolved
2013-03-30 15:26 jK Resolution open => fixed
2013-03-30 15:26 jK Assigned To => jK