View Issue Details

IDProjectCategoryView StatusLast Update
0003542Spring engineGeneralpublic2013-03-11 23:02
Reportersmoth Assigned ToKloot  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0003542: camera angle breaks sun visual
Description
When in fps camera, at a low angle the sun gets sheered in half at a certain point.

terribly bad for screenshots. Using the default settings for the "dawn" map option in blue print you can see this..

(note version is 93 because 93 is all that is available.)
(note colors in shot have been altered away from the default blueprint)
TagsNo tags attached.
Attached Files
screen00685.jpg (Attachment missing)
broken sun.jpg (Attachment missing)
shot1.jpg (Attachment missing)
Checked infolog.txt for Errors

Activities

abma

2013-03-10 09:26

administrator   ~0010022

still present in 93.0?


why didn't you write the Version you used? also, the Version field is optional...

cleanrock

2013-03-10 10:20

reporter   ~0010023

Still present in 93.
I attached a screenshot when using glBlendFunc(GL_ONE, GL_ZERO) in UpdateSunFlare().
Looks like some kind of clipping is going on, my guess is near plane clipping.

Kloot

2013-03-10 13:15

developer   ~0010024

Last edited: 2013-03-10 13:18

Does not reproduce for me with either sky mode.

e: correction, it does, but only near the corners of the viewport

cleanrock

2013-03-10 14:41

reporter   ~0010026

kloot, bug is more visible if sun is near horizon:
--- a/rts/Map/MapInfo.cpp
+++ b/rts/Map/MapInfo.cpp
@@ -187,6 +187,7 @@ void CMapInfo::ReadLight()
                light.sunDir = lightTable.GetFloat3("sunDir", float3(0.0f, 1.0f, 2.0f));
                light.sunDir.w = FLT_MAX;
        }
+ light.sunDir = float3(0.0f, 0.5f, 2.0f); // TODO remove
        light.sunDir.ANormalize();
 
        light.groundAmbientColor = lightTable.GetFloat3("groundAmbientColor", float3(0.5f, 0.5f, 0.5f));

Issue History

Date Modified Username Field Change
2013-03-10 01:02 smoth New Issue
2013-03-10 01:02 smoth File Added: screen00685.jpg
2013-03-10 01:02 smoth File Added: broken sun.jpg
2013-03-10 09:26 abma Note Added: 0010022
2013-03-10 09:27 abma Status new => feedback
2013-03-10 09:27 abma Product Version 93.0 =>
2013-03-10 09:27 abma Description Updated
2013-03-10 10:20 cleanrock Note Added: 0010023
2013-03-10 10:23 cleanrock File Added: shot1.jpg
2013-03-10 13:15 Kloot Note Added: 0010024
2013-03-10 13:18 Kloot Note Edited: 0010024
2013-03-10 14:41 cleanrock Note Added: 0010026
2013-03-10 15:45 Kloot Assigned To => Kloot
2013-03-10 15:45 Kloot Status feedback => assigned
2013-03-10 20:50 Kloot Changeset attached => spring develop 4d625ff8
2013-03-10 20:50 Kloot Status assigned => resolved
2013-03-10 20:50 Kloot Resolution open => fixed
2013-03-11 23:02 Kloot Changeset attached => spring release 2d6bb553