View Issue Details

IDProjectCategoryView StatusLast Update
0003435Spring engineGeneralpublic2013-02-03 12:39
ReporterKingRaptor Assigned ToKloot  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionreopened 
Summary0003435: (91.0.1) New nanospray system is broken
Description1) The piecenumbers passed to Spring.SetUnitNanoPieces often don't match the return values of Spring.GetUnitNanoPieces at all. Passing the piecenumbers through Spring.GetUnitScriptPiece before using them (on either end) fails to resolve the issue.

2) A unit can emit nanospray from two pieces despite having only one nanopiece set. This was observed on the ZK Strike Commander (armcom1); removing the script.QueryNanoPiece callin in the LUS fixes the issue, suggesting to me that the caching of the QueryNanoPiece return values is bugged.
Steps To Reproduce1) Start Zero-K test r9208.
2) Select the Strike Commander at start (or wait for the automatically spawned commander).
3) Build something for around 1 s.
4) Build something else. The nanospray will now emit from two different points.
5) /cheat, /give armrectr
6) Have the Rector build something. The engine and LUPS nanospray will originate from two different points. Compare the input and output piece numbers echoed to console.
Additional InformationRelevant files:
armcom script http://code.google.com/p/zero-k/source/browse/trunk/mods/zk/scripts/armcom.lua
92.0 LUPS gadget: http://code.google.com/p/zero-k/source/browse/trunk/mods/zk/LuaRules/Gadgets/lups_nano_spray.lua
ZK gadget for setting nanopieces for COB-scripted units: http://code.google.com/p/zero-k/source/browse/trunk/mods/zk/LuaRules/Gadgets/unit_setnanopiece.lua
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Kloot

2013-02-02 18:56

developer   ~0009689

Last edited: 2013-02-02 18:56

please test http://springrts.com/dl/buildbot/default/release/91.0.1-1280-ga5c4912/ when it becomes available

Kloot

2013-02-03 01:01

developer   ~0009692

Assumed fixed, reopen if not.

KingRaptor

2013-02-03 11:50

reporter   ~0009697

The nanospray-from-two-pieces bug still exists, although it's a minor issue.

Issue History

Date Modified Username Field Change
2013-02-02 17:45 KingRaptor New Issue
2013-02-02 18:47 Kloot Assigned To => Kloot
2013-02-02 18:47 Kloot Status new => assigned
2013-02-02 18:53 Kloot Changeset attached => spring release a5c49129
2013-02-02 18:53 Kloot Status assigned => resolved
2013-02-02 18:53 Kloot Resolution open => fixed
2013-02-02 18:56 Kloot Note Added: 0009689
2013-02-02 18:56 Kloot Status resolved => feedback
2013-02-02 18:56 Kloot Resolution fixed => reopened
2013-02-02 18:56 Kloot Note Edited: 0009689
2013-02-03 01:01 Kloot Note Added: 0009692
2013-02-03 01:01 Kloot Status feedback => resolved
2013-02-03 01:01 Kloot Resolution reopened => fixed
2013-02-03 11:50 KingRaptor Note Added: 0009697
2013-02-03 11:50 KingRaptor Status resolved => feedback
2013-02-03 11:50 KingRaptor Resolution fixed => reopened
2013-02-03 12:39 Kloot Changeset attached => spring release dc8940f1
2013-02-03 12:39 Kloot Status feedback => resolved