| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003428 | Spring engine | General | public | 2013-01-30 17:30 | 2013-01-30 22:05 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 91.0.1+git | ||||||||
| Target Version | Fixed in Version | 92.0 | |||||||
| Summary | 0003428: osx compile-warnings: OBJParser.cpp & S3OParser.cpp: warning: invalid access to non-static data member ... | ||||||||
| Description | http://buildbot.springrts.com/builders/quick-macosx/builds/1698/steps/buildConfig/logs/warnings%20%28192%29 | ||||||||
| Additional Information | /buildbot/springrts/quick-macosx/build/rts/Rendering/Models/OBJParser.cpp:530: warning: invalid access to non-static data member 'float3::<anonymous union>::<anonymous struct>::x' of NULL object | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2013-01-30 18:46 |
blame zerver for a972ed080ce76cd82d853d0031278e6cd3a7129c |
|
abma (administrator) 2013-01-30 19:05 |
https://github.com/spring/spring/commit/a972ed080ce76cd82d853d0031278e6cd3a7129c |
|
zerver (reporter) 2013-01-30 21:30 |
Hm, a vector.reserve(vector.size()+1) is maybe enough to prevent a crash? |
|
cleanrock (reporter) 2013-01-30 21:36 |
Is there a way to reproduce this crash so we can know for sure what was/is wrong ? (I get the impression that the commit/fix is a guess and not really tested) |
|
abma (administrator) 2013-01-30 21:56 |
https://github.com/spring/spring/commit/61cc6c46e2ed631c289177f926326e9fb3005a39 |
|
zerver (reporter) 2013-01-30 22:04 |
cleanrock: No, it is 100% clear why it crashes. glBufferData reads outside the vector bounds, because the read may start at a non-zero offset of the first element, depending on which member is referenced using the address-of operator (&). https://github.com/spring/spring/commit/73213ba3751d7caeecae36b45e45004eb96ffc5c |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-01-30 17:30 | abma | New Issue | |
| 2013-01-30 17:31 | abma | Summary | osx compile-warnings: OBJParser.cpp:530: warning: invalid access to non-static data member ... => osx compile-warnings: OBJParser.cpp & S3OParser.cpp: warning: invalid access to non-static data member ... |
| 2013-01-30 18:46 | Kloot | Note Added: 0009670 | |
| 2013-01-30 19:05 | abma | Note Added: 0009671 | |
| 2013-01-30 21:30 | zerver | Note Added: 0009673 | |
| 2013-01-30 21:36 | cleanrock | Note Added: 0009674 | |
| 2013-01-30 21:56 | abma | Note Added: 0009675 | |
| 2013-01-30 21:56 | abma | Status | new => resolved |
| 2013-01-30 21:56 | abma | Resolution | open => fixed |
| 2013-01-30 21:56 | abma | Assigned To | => abma |
| 2013-01-30 22:04 | zerver | Note Added: 0009676 | |
| 2013-01-30 22:04 | zerver | Status | resolved => feedback |
| 2013-01-30 22:04 | zerver | Resolution | fixed => reopened |
| 2013-01-30 22:05 | zerver | Status | feedback => resolved |
| 2013-01-30 22:05 | zerver | Fixed in Version | => 92.0 |
| 2013-01-30 22:05 | zerver | Resolution | reopened => fixed |
| Issue History |