View Issue Details

IDProjectCategoryView StatusLast Update
0003398Spring engineGeneralpublic2013-02-07 13:47
Reporterabma Assigned ToKloot  
PrioritynormalSeveritycrashReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version91.0.1+git 
Target Version92.0Fixed in Version91.0.1+git 
Summary0003398: sync error in E323 validation test
Descriptionfirst seen desync: (could be still eariler)

http://buildbot.springrts.com/builders/validationtests/builds/2166/steps/validation%20test_4/logs/stdio

current desync run:

http://buildbot.springrts.com/builders/validationtests/builds/2179/steps/validation%20test_4/logs/stdio
Additional Informationhttp://springrts.com/dl/buildbot/default/develop/91.0.1-770-g52c6cda/validation/
->
demos/20130114_165741_Altair_Crossing-V1_91.0.1-770-g52c6cda develop.sdf
demos/20130114_165742_Altair_Crossing-V1_91.0.1-770-g52c6cda develop.sdf
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

cleanrock

2013-01-15 08:22

reporter   ~0009599

for reference:
"first seen desync" is
91.0.1-749-g4139b7d
https://github.com/spring/spring/commit/4139b7dfd2b413e56435977ef3867239eb6a1bf7

Kloot

2013-01-16 21:55

developer   ~0009606

Last edited: 2013-01-16 21:55

just a note: *if* E323AI uses the engine pathfinder callbacks, it will desync in multiplayer when QTPFS is enabled (making that support unsynced execution is still a TODO)

I do not see how 4139b7dfd2b413e56435977ef3867239eb6a1bf7 could be responsible, most likely a false positive.

abma

2013-01-19 14:20

administrator   ~0009616

dumb question, how to check? i couldn't find any calls to these functions, but i'm not sure if i searched for the correct includes / function names.

the validation test uses QTPFS...

Kloot

2013-02-06 16:05

developer   ~0009719

any of these in AI/Wrappers/LegacyCpp/IAICallback.h:

  virtual int InitPath(float3 start, float3 end, int pathType, float goalRadius = 8) = 0;
  virtual float3 GetNextWaypoint(int pathId) = 0;
  virtual void FreePath(int pathId) = 0;
  virtual float GetPathLength(float3 start, float3 end, int pathType, float goalRadius = 8) = 0;

abma

2013-02-07 02:38

administrator   ~0009720

there is one i guess:
https://github.com/Error323/E323AI/blob/master/CPathfinder.cpp#L342

Kloot

2013-02-07 13:47

developer   ~0009722

should not desync anymore with 32d52706ef (but E323AI might behave strangely as a result)

Issue History

Date Modified Username Field Change
2013-01-14 20:59 abma New Issue
2013-01-15 08:22 cleanrock Note Added: 0009599
2013-01-16 21:55 Kloot Note Added: 0009606
2013-01-16 21:55 Kloot Note Edited: 0009606
2013-01-19 14:20 abma Note Added: 0009616
2013-02-06 12:03 abma Status new => feedback
2013-02-06 16:05 Kloot Note Added: 0009719
2013-02-07 02:38 abma Note Added: 0009720
2013-02-07 02:38 abma Status feedback => new
2013-02-07 13:47 Kloot Note Added: 0009722
2013-02-07 13:47 Kloot Status new => resolved
2013-02-07 13:47 Kloot Fixed in Version => 91.0.1+git
2013-02-07 13:47 Kloot Resolution open => fixed
2013-02-07 13:47 Kloot Assigned To => Kloot