| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003338 | Spring engine | General | public | 2012-11-22 15:36 | 2012-12-05 22:08 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 91.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003338: procmon says .sdz archives are read byte by byte | ||||||||
| Description | 15:34:39,3495601 spring.exe 3700 ReadFile D:\Games\Spring\games\zk-v1.0.4.4.sdz SUCCESS Offset: 179.875.506, Length: 1 7z. files should be read block-wise. doing 1-byte should be horrible slow... not sure at which point this happens, needs more investigation | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2012-11-23 09:24 |
investigated it a bit. 1 byte reads seems to come from getting archive file listing... |
|
abma (administrator) 2012-11-23 09:28 |
https://github.com/spring/spring/blob/91.0/rts/System/FileSystem/ZipArchive.cpp#L46 |
|
abma (administrator) 2012-11-25 01:32 |
fixed by removing code :-) https://github.com/spring/spring/commit/44abb8312fc0439dd0796559e9b178f272ee64ee |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-11-22 15:36 | abma | New Issue | |
| 2012-11-23 09:18 | abma | Summary | procmon says .7z archives are read byte by byte => procmon says .sdz archives are read byte by byte |
| 2012-11-23 09:24 | abma | Note Added: 0009366 | |
| 2012-11-23 09:28 | abma | Note Added: 0009367 | |
| 2012-11-25 01:32 | abma | Note Added: 0009375 | |
| 2012-11-25 01:32 | abma | Status | new => resolved |
| 2012-11-25 01:32 | abma | Resolution | open => fixed |
| 2012-11-25 01:32 | abma | Assigned To | => abma |
| 2012-12-05 22:07 | abma | Changeset attached | => spring develop 44abb831 |
| Issue History |