View Issue Details

IDProjectCategoryView StatusLast Update
0003166Spring engineGeneralpublic2012-07-26 00:02
Reporterzerver Assigned Tozerver  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version89.0 
Fixed in Version89.0.1+git 
Summary0003166: The network connection is not properly closed when an error occurs
DescriptionTitle says it
Steps To ReproduceStart a game where you don't have the map. If you try to connect with a map shortly thereafter it says you are already ingame.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2012-07-10 21:28

administrator   ~0008942

shouldn't a reconnect with the correct password close other connections?!

zerver

2012-07-11 00:17

reporter   ~0008947

You probably want to have some kind of timeout first, to make it impossible for two simultaneously running instances to fight for a single connection. The default timeout is 15s, perhaps a bit too much.

But we should also send NETMSG_QUIT if exception is caught during load.

abma

2012-07-11 00:37

administrator   ~0008948

Last edited: 2012-07-11 00:38

thats not what i meant: (i don't know how the handshake works)

client one connects with correct password: connection accepted
client two connects with the same password: first connection gets dropped / banned / ...?!, connection two accepted

i guess one of the first packets is the pw and its only sent once?!

zerver

2012-07-26 00:02

reporter   ~0009084

https://github.com/spring/spring/commit/62a3318d29ba809119e6096e7d3596d4f644cb68

Issue History

Date Modified Username Field Change
2012-07-10 15:21 zerver New Issue
2012-07-10 21:28 abma Note Added: 0008942
2012-07-11 00:17 zerver Note Added: 0008947
2012-07-11 00:37 abma Note Added: 0008948
2012-07-11 00:38 abma Note Edited: 0008948
2012-07-17 03:08 zerver Assigned To => zerver
2012-07-17 03:08 zerver Status new => assigned
2012-07-26 00:02 zerver Note Added: 0009084
2012-07-26 00:02 zerver Status assigned => resolved
2012-07-26 00:02 zerver Fixed in Version => 89.0.1+git
2012-07-26 00:02 zerver Resolution open => fixed