0002885: The team death message is nonstandard English.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002885

Spring engine

General

public

2011-12-29 10:58

2013-08-25 19:16

Reporter

Nemo

Assigned To

Priority

normal

Severity

text

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

Target Version

Fixed in Version

Summary

0002885: The team death message is nonstandard English.

Description

The team death message: "Team X (lead by PlayerName) is no more" is nonstandard English: should be "Team X (led by PlayerName) is no more." - it's the passive form, so you need the past participle. A period at the end wouldn't hurt either :P

As an aside, this message changed at some point pretty quietly, thereby breaking all custom team death messages in games that were catching and replacing the default (here's the fix that KingRaptor made to ZK to bring them back: http://code.google.com/p/zero-k/source/diff?spec=svn4815&r=4815&format=side&path=/trunk/mods/zk/gamedata/messages.lua ) Not a big deal, but would have been nice to have an announcement.

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes
~0008034 FLOZi (reporter) 2011-12-29 15:37 Last edited: 2011-12-29 15:38	Guess who? https://github.com/spring/spring/commit/9ca6eb2292c12713b5b2e3ca9ae33fa58af7f707#rts/Sim/Misc/Team.cpp Anyway, games should probably deal with this themselves now, should have been moved out when game ends conditions was.

~0011398 jK (developer) 2013-08-25 19:16	afaik fixed also lua customizable

Notes

Date Modified	Username	Field	Change
Issue History
2011-12-29 10:58	Nemo	New Issue
2011-12-29 15:37	FLOZi	Note Added: 0008034
2011-12-29 15:38	FLOZi	Note Edited: 0008034
2013-08-25 19:16	jK	Note Added: 0011398
2013-08-25 19:16	jK	Status	new => resolved
2013-08-25 19:16	jK	Resolution	open => fixed
2013-08-25 19:16	jK	Assigned To	=> jK

Issue History