View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000279 | Spring engine | General | public | 2006-08-25 10:46 | 2007-05-30 19:48 |
| Reporter | KDR_11k | Assigned To | tvo | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000279: [patch] Dead units remain as target until Killed returns | ||||
| Description | Any unit using Killed() to show a death animation remains as a target for all attackers until Killed() returns and the unit is destroyed. I don't think that's the intended effect, it makes death animations a bad idea for most mods. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
Further testing revealed that units with a death animation that self destruct remain reclaimable. Since self destruct doesn't zero the unit's HP it can be normally reclaimed (and gives the ressource boost) if the reclaimers can get the unit's HP to deplete before Killed() returns. In that case it still remains on the map, just with zero HP. |
|
|
Here is a patch (no-dead-targetting.patch) that (hopefully) fixes the targetting of dying units. At least in my test units stopped to fire at a target once it reached 0 health. |
|
|
Here is a better version of the patch (no-dead-and-crashing-targetting.patch). Now it uses isDead and crashing unit flags, so that there is no float comparisons. Also now it prevents targetting of crashing aircraft. |
|
|
added [patch] in topic for easier filtering |
|
|
Committed, thanks you for your contribution yuritch, and KDR_11k for filing the bug in the first place ;-) (r3803) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-08-25 10:46 | KDR_11k | New Issue | |
| 2006-08-26 21:58 | KDR_11k | Note Added: 0000341 | |
| 2007-05-09 18:58 | yuritch | File Added: no-dead-targetting.patch | |
| 2007-05-09 19:00 | yuritch | Note Added: 0000905 | |
| 2007-05-12 13:25 | yuritch | File Added: no-dead-and-crashing-targetting.patch | |
| 2007-05-12 13:27 | yuritch | Note Added: 0000908 | |
| 2007-05-20 22:21 | tvo | Note Added: 0000910 | |
| 2007-05-20 22:21 | tvo | Summary | Dead units remain as target until Killed returns => [patch] Dead units remain as target until Killed returns |
| 2007-05-30 19:48 | tvo | Status | new => assigned |
| 2007-05-30 19:48 | tvo | Assigned To | => tvo |
| 2007-05-30 19:48 | tvo | Status | assigned => resolved |
| 2007-05-30 19:48 | tvo | Resolution | open => fixed |
| 2007-05-30 19:48 | tvo | Note Added: 0000922 |
