View Issue Details

IDProjectCategoryView StatusLast Update
0002757Spring engineGeneralpublic2011-11-24 01:26
ReporterBrainDamage Assigned Toabma  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionno change required 
Product Version84.0 
Summary0002757: Midgame join and rejoin are broken after the game has started
DescriptionMidgame join and rejoin are broken after the game has started, one can rejoin & dynamic join in pregame phase fine
I suspect canReconnect is always set to false in Game/GameServer.cpp
because:
    if (!canReconnect && !allowAdditionalPlayers)
        packetCache.clear(); // free memory

    if (UDPNet && !canReconnect && !allowAdditionalPlayers)
        UDPNet->Listen(false); // don't accept new connections
since spring doesn't appear to be listening anymore to new connections after game has started
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2011-11-24 01:02

administrator   ~0007664

Last edited: 2011-11-24 01:11

that was changed a few commits ago...

https://github.com/spring/spring/commit/2607f60607b4f0b168f34f5fa87077cafe06c059

related?

zerver

2011-11-24 01:10

reporter   ~0007666

I think it is caused by old config file for the server

Delete this line:
ReconnectTimeout = 0

BrainDamage

2011-11-24 01:22

developer   ~0007667

confirmed that deleting ReconnectTimeout = 0 fixes it

abma

2011-11-24 01:26

administrator   ~0007668

Last edited: 2011-11-24 01:31

thx for reporting! :-)


i added a note to the release-thread: http://springrts.com/phpbb/viewtopic.php?f=2&t=27137&p=505767#p505767

Issue History

Date Modified Username Field Change
2011-11-24 00:58 BrainDamage New Issue
2011-11-24 01:02 abma Note Added: 0007664
2011-11-24 01:10 zerver Note Added: 0007666
2011-11-24 01:10 abma Note Edited: 0007664
2011-11-24 01:11 abma Note Edited: 0007664
2011-11-24 01:22 BrainDamage Note Added: 0007667
2011-11-24 01:26 abma Note Added: 0007668
2011-11-24 01:26 abma Status new => resolved
2011-11-24 01:26 abma Resolution open => no change required
2011-11-24 01:26 abma Assigned To => abma
2011-11-24 01:31 abma Note Edited: 0007668