| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002716 | Spring engine | AI | public | 2011-11-07 17:02 | 2013-08-05 01:16 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | sometimes | ||||
| Status | resolved | Resolution | no change required | ||||||
| Product Version | 83.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0002716: KAIK gets events from already died units | ||||||||
| Description | most ai's have similar checks: https://github.com/Kaylewt/KAIK/blob/master/KAIK.cpp#L123 https://github.com/Kaylewt/KAIK/blob/master/KAIK.cpp#L151 imo this should be either done in the interface or already checked by the engine. | ||||||||
| Additional Information | or am i wrong? imo it makes no sense to receive a UnitDamaged / UnitIdle event from a dead unit. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2011-11-07 18:05 Last edited: 2011-11-07 18:05 |
at least wrt. UnitDamaged the engine does first check if a unit is dead (it might not have at the time those lines were added to AIs, they are old), the other callins would have to be tested. |
|
abma (administrator) 2011-11-07 18:34 Last edited: 2011-11-07 18:35 |
uhm... no... if i add a printf after both lines they'll be called (just do a /give all, /give all 1, when KAIK is player 1) UnitDamaged and UnitIdle is called with a dead unit. |
|
abma (administrator) 2011-11-07 18:39 |
this change: http://pastebin.com/TWMU9EhG output after give all 0+1 (kaik as player 1) [...spam...] UnitDamaged dead unit!!!! UnitIdle dead unit!!!! [...spam...] |
|
Kloot (developer) 2011-11-07 19:08 |
That could mean KAIK does not keep track of the isDead property (a member of KAIK's own CUNIT class) correctly. Add prints on the engine side to be sure. |
|
abma (administrator) 2011-11-08 03:33 Last edited: 2011-11-08 03:34 |
doh! yep, thats correct, seems to be an issue in kaik... feel free to close it if no change is required... |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-07 17:02 | abma | New Issue | |
| 2011-11-07 18:05 | Kloot | Note Added: 0007532 | |
| 2011-11-07 18:05 | Kloot | Severity | major => minor |
| 2011-11-07 18:05 | Kloot | Note Edited: 0007532 | |
| 2011-11-07 18:34 | abma | Note Added: 0007533 | |
| 2011-11-07 18:35 | abma | Note Edited: 0007533 | |
| 2011-11-07 18:39 | abma | Note Added: 0007534 | |
| 2011-11-07 19:08 | Kloot | Note Added: 0007535 | |
| 2011-11-08 03:33 | abma | Note Added: 0007538 | |
| 2011-11-08 03:33 | abma | Summary | ais get events from already died units => KAIK gets events from already died units |
| 2011-11-08 03:34 | abma | Note Edited: 0007538 | |
| 2011-11-08 03:34 | abma | Severity | minor => tweak |
| 2013-08-05 01:16 | abma | Status | new => resolved |
| 2013-08-05 01:16 | abma | Resolution | open => no change required |
| 2013-08-05 01:16 | abma | Assigned To | => abma |
| Issue History |