| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002558 | Spring engine | Unit Scripting | public | 2011-07-14 20:52 | 2011-07-14 22:14 | ||||
| Reporter | FLOZi | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | Fixed in Version | 0.82.7+git | |||||||
| Summary | 0002558: UnitLoaded callin is called when unit is Unloaded | ||||||||
| Description | To be more precise, the UnitLoaded event and therefore lua callin, is called whenever AttachUnit is called in the transports script. This is slightly problematic as often in a transport script, when a unit is picked up it is attached to the fictitious '-1' piece so that the unit is hidden. However when dropping, the unit is attached to another piece which is moved by the script to the drop point given to it by the engine. Another example is a transport with an open bay; passengers are often attached to their own 'seat' piece within the model, then re attached to the loading arm when they are being unloaded. | ||||||||
| Additional Information | I believe it would be preferable from a game dev PoV if this was corrected. As a bonus it would allow fixing http://springrts.com/mantis/view.php?id=2127 more easily via a gadget. Furthermore, DetachUnit is always called when AttachUnit is. If possible this would ideally be avoided when attaching to another piece *on the same transport*. This is at least partly responsible for http://springrts.com/mantis/view.php?id=1836 I'm willing to attempt to tackle this myself, but I'll need to talk to someone about the best implementation (and if avoiding Detatch when re-attaching is plausible) | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
FLOZi (reporter) 2011-07-14 20:56 |
Additional note; despite the version field, this has been the case since at least the two other reports mentioned. Most likely it has always been the case since lua callins were introduced. |
|
Kloot (developer) 2011-07-14 22:14 |
If you want to test: f204c7c6032fb2d53593bc9a88d806f115f45101 (should cover both points) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-07-14 20:52 | FLOZi | New Issue | |
| 2011-07-14 20:52 | FLOZi | Graphics Card | => unknown |
| 2011-07-14 20:56 | FLOZi | Note Added: 0007032 | |
| 2011-07-14 22:03 | Kloot | Status | new => assigned |
| 2011-07-14 22:14 | Kloot | Note Added: 0007034 | |
| 2011-07-14 22:14 | Kloot | Status | assigned => resolved |
| 2011-07-14 22:14 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-07-14 22:14 | Kloot | Resolution | open => fixed |
| 2011-07-14 22:14 | Kloot | Assigned To | => Kloot |
| Issue History |