View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002537Spring engineGeneralpublic2011-07-06 01:082011-10-26 19:23
Reporteruser744Assigned Toabma  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version0.82.7+git 
Target Version83.0 
Summary0002537: sort out which lua widgets should be included with engine
DescriptionThe engine ships with many widgets that could be game side.
Should be sorted out.
Disabling is not enough because they still show up in the F11 menu.
Additional Informationhttp://springrts.com/phpbb/viewtopic.php?f=12&t=26404&start=4

Some other widgets that are currently included in the engine but could be mod side only:
unit_factory_guard.lua
unit_immobile_buider.lua
unit_metal_maker.lua
unit_stockpile.lua
Those are very game specific, imo no need to have those in the engine.

Then they are some, which are can be usefull for basically every game:
gui_xray_shader.lua
gui_team_platter.lua
gui_selbuttons.lua
gui_hilight_unit.lua
camera_smooth_move.lua
camera_shake.lua
But even those do not really need to be in the engine?

Actually almost all widgets could be removed, except maybe headless_setup.lua
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2011-07-06 01:27

administrator   ~0006932

so... move them to something like docs/examples ?

user744

2011-07-06 02:19

  ~0006933

Last edited: 2011-07-06 02:26

 Not sure if examples should be in installer like that?
widget database seems more suited (http://springrts.com/wiki/WidgetDatabaseFAQ )

Also:
https://github.com/spring/spring/tree/master/cont/base/springcontent/LuaGadgets/Gadgets

see readme.txt: "This directory contains some example gadgets."
So there already are some Lua examples in springcontent.sdz, not the best place imo.
Maybe that could be combined?

For start, they could simply be moved into some "old default widgets" folder so if a mod does not get updated, players can simply copy the files back.

hoijui

2011-07-08 11:31

reporter   ~0006964

yeah, i also think widget-DB and/or some folder under cont/ (Content fits better then Documentation (doc/)) would be good.
And LuaGadgets as examples folder for LuaRules is also strange. LuaRules_examples or the like would be easier to grasp. Something similar for LuaUI maybe (LuaUI_examples)?

FLOZi

2011-07-08 15:03

reporter   ~0006971

You should remember that LuaGadgets also houses the base content gadgethandler. Although I'm still not sure why that isn't just in LuaRules anyway.

abma

2011-09-13 23:51

administrator   ~0007367

init_start_marker.lua
headless_setup.lua

should be moved to examples, too.

abma

2011-09-14 00:28

administrator   ~0007370

https://github.com/spring/spring/commit/8844dac8e2e9577fe0bb5328c4134cdbd95b6fd7

i moved all to examples, because they where disabled as default

user744

2011-10-21 16:15

  ~0007464

two files are still in LuaUI\Widgets:
gui_buildspacing.lua
minimap_startbox.lua

abma

2011-10-26 19:08

administrator   ~0007470

i kept these because they were enabled as default... was to afraid to remove them, because someone could complain about them.

abma

2011-10-26 19:23

administrator   ~0007471

https://github.com/spring/spring/commit/28cc7201febb948974de845611319d0fe888c63d

Issue History

Date Modified Username Field Change
2011-07-06 01:08 user744 New Issue
2011-07-06 01:08 user744 Graphics Card => unknown
2011-07-06 01:27 abma Note Added: 0006932
2011-07-06 01:27 abma Target Version => 0.83.0
2011-07-06 02:19 user744 Note Added: 0006933
2011-07-06 02:26 abma Note Edited: 0006933
2011-07-08 11:31 hoijui Note Added: 0006964
2011-07-08 15:03 FLOZi Note Added: 0006971
2011-09-13 23:49 abma Summary sort out which widgets should be included with engine => sort out which lua widgets should be included with engine
2011-09-13 23:51 abma Note Added: 0007367
2011-09-14 00:28 abma Note Added: 0007370
2011-09-14 00:28 abma Status new => resolved
2011-09-14 00:28 abma Resolution open => fixed
2011-09-14 00:28 abma Assigned To => abma
2011-10-21 16:15 user744 Note Added: 0007464
2011-10-21 16:15 user744 Status resolved => feedback
2011-10-21 16:15 user744 Resolution fixed => reopened
2011-10-26 19:08 abma Note Added: 0007470
2011-10-26 19:23 abma Note Added: 0007471
2011-10-26 19:23 abma Status feedback => resolved
2011-10-26 19:23 abma Resolution reopened => fixed