| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002507 | Spring engine | Lua | public | 2011-07-01 12:52 | 2011-07-02 12:30 | ||||
| Reporter | KingRaptor | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | Fixed in Version | 0.82.7+git | |||||||
| Summary | 0002507: (master) Spring.GameOver is broken | ||||||||
| Description | Passing an empty table in Spring.GameOver() results in the following error: Player UnnamedPlayer sent invalid GameOver: invalid size for NETMSG_GAMEOVER (no winning allyteams received) When a table with at least one allyTeam is passed, nothing happens (stats not displayed, Spring.IsGameOver() returns false, etc.) | ||||||||
| Additional Information | Tested with ZK (dev version) | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2011-07-01 22:30 |
This code... function gadget:UnitDestroyed(unitID, unitDefID, unitTeam) winningAllyTeams = {[1] = 1} Spring.GameOver(winningAllyTeams) end ...works just fine. |
|
KingRaptor (reporter) 2011-07-02 08:38 |
Tried again, results: Spring.Echo(Spring.IsGameOver()) before Spring.GameOver indicates that IsGameOver is indeed set from false to true, so my description was mistaken. However, the stats screen is not displayed and gadget:GameOver() is not called. |
|
Kloot (developer) 2011-07-02 12:29 |
why the stats screen is not displayed in ZK: awards.lua calls spSendCommands({'endgraph 0'}) (debug your own code next time) why GameOver did not trigger: there was a signature mismatch between the virtual function and its overridden version. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-07-01 12:53 | KingRaptor | New Issue | |
| 2011-07-01 12:53 | KingRaptor | Graphics Card | => unknown |
| 2011-07-01 16:54 | hoijui | Build | => 0.82.3-2384-g0387e6a |
| 2011-07-01 16:54 | hoijui | Additional Information Updated | |
| 2011-07-01 22:30 | Kloot | Note Added: 0006841 | |
| 2011-07-01 22:30 | Kloot | Status | new => feedback |
| 2011-07-02 08:38 | KingRaptor | Note Added: 0006846 | |
| 2011-07-02 12:29 | Kloot | Note Added: 0006850 | |
| 2011-07-02 12:30 | Kloot | Status | feedback => resolved |
| 2011-07-02 12:30 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-07-02 12:30 | Kloot | Resolution | open => fixed |
| 2011-07-02 12:30 | Kloot | Assigned To | => Kloot |
| Issue History |