| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002456 | Spring engine | Lua | public | 2011-06-01 18:12 | 2011-06-21 21:21 | ||||
| Reporter | abma | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | duplicate | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | 83.0 | Fixed in Version | |||||||
| Summary | 0002456: (master) morphing doesn't work | ||||||||
| Description | [f=0018822] LuaRules::RunCallIn: error = 2, GameFrame, [string "LuaRules/Gadgets/unit_morph.lua"]:521: 'for' limit must be a num tested in Tech Annihilation + Spring 1944 + Zero-K Zero-K: LuaRules::RunCallIn: error = 2, GameFrame, [string "LuaRules/Gadgets/unit_morph.lua"]:602: 'for' limit must be a number | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
Kloot (developer) 2011-06-01 18:49 |
caused by https://github.com/spring/spring/commit/10219eed4ee93096dd84733026be61e8f311d83d#diff-2 (note the removal of "hs_n.PushNumber(L, i)") Since this was done for other Lua API functions as well, I assume the changes are intentional (so https://github.com/spring/spring/commit/bbe00286444af757a215e445f2cc888d64417a0f is probably unwanted) and *gets should be rewritten to use #table instead of table.n, but ask jK for confirmation. |
|
abma (administrator) 2011-06-12 04:51 |
see 0002467 for updates of this |
|
abma (administrator) 2011-06-21 21:21 |
Kloot, can you please review hoijuis commit? i'm unsure about it because you added more stuff when reverting it: https://github.com/spring/spring/commit/1874b58f97d7cfab84decdb4ff5f36a810fa9336#L4L1625 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-06-01 18:12 | abma | New Issue | |
| 2011-06-01 18:49 | Kloot | Note Added: 0006699 | |
| 2011-06-01 18:50 | Kloot | Status | new => feedback |
| 2011-06-10 16:09 | hoijui | Target Version | => 0.83.0 |
| 2011-06-12 04:51 | abma | Note Added: 0006730 | |
| 2011-06-12 04:51 | abma | Relationship added | duplicate of 0002467 |
| 2011-06-12 04:51 | abma | Duplicate ID | 0 => 2467 |
| 2011-06-12 04:51 | abma | Status | feedback => resolved |
| 2011-06-12 04:51 | abma | Resolution | open => duplicate |
| 2011-06-12 04:51 | abma | Assigned To | => abma |
| 2011-06-21 21:21 | abma | Note Added: 0006798 | |
| Issue History |