| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002350 | Spring engine | Lua | public | 2011-02-15 07:37 | 2011-03-02 15:52 | ||||
| Reporter | abma | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 0.82.7+git | |||||||
| Summary | 0002350: mex upgrade isn't displayed in commands in spring master | ||||||||
| Description | the button is simply missing... | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2011-02-16 16:26 |
Is it a gadget? All gadget added commands are missing in ZK too. |
|
Kloot (developer) 2011-02-19 16:20 Last edited: 2011-02-19 16:33 |
The reason unit_mex_upgrader no longer adds a command button is that the way it detects builders (function determine()) relies on a LuaUnitDef field (isBuilder) that is nil in master builds. function isBuilder(unitDef) return (unitDef.isBuilder and unitDef.canAssist) end As a temporary workaround, a gadget can check whether buildSpeed > 0 (which is what the engine also does to sanitize stray builder=1 values). |
|
abma (administrator) 2011-02-19 19:22 |
seems to work: https://github.com/abma/spring-test-game/commit/0e42336ae9b4fac823af0c83b1a99f83f3c677af @kloot: why status feedback? |
|
Kloot (developer) 2011-03-02 15:52 |
re-added the isBuilder field (marked deprecated, unitDef.builder should be used instead) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-02-15 07:37 | abma | New Issue | |
| 2011-02-16 16:26 | Google_Frog | Note Added: 0006395 | |
| 2011-02-19 16:20 | Kloot | Note Added: 0006402 | |
| 2011-02-19 16:20 | Kloot | Status | new => feedback |
| 2011-02-19 16:33 | Kloot | Note Edited: 0006402 | |
| 2011-02-19 19:22 | abma | Note Added: 0006403 | |
| 2011-03-02 15:52 | Kloot | Note Added: 0006459 | |
| 2011-03-02 15:52 | Kloot | Status | feedback => resolved |
| 2011-03-02 15:52 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-03-02 15:52 | Kloot | Resolution | open => fixed |
| 2011-03-02 15:52 | Kloot | Assigned To | => Kloot |
| Issue History |