View Issue Details

IDProjectCategoryView StatusLast Update
0002255Spring engineGeneralpublic2010-12-15 10:50
ReporterLicho Assigned ToKloot  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.82.6.1 
Fixed in Version0.82.7 
Summary0002255: Spring UDPlistener gets bound to wrong IP if there are multiple addresses - ignores HostIP
DescriptionUDPListener uses "Any()" as bound address.

On machines with multiple IPs (which is springrts.com too - both linux and windows parts) it gets bound to incorrect IP - like local LAN IP.

Even if script contains set HostIP, spring still insist on using Any with unpredictable results.

Code is here:
https://github.com/spring/spring/blob/master/rts/System/Net/UDPListener.cpp#L59



To fix it, make it use HostIP if defined, otherwise Any.

This issue causes problems to relay host (workaround solution was possible) and recently to my attempts to move autohosts to windows VM to remove lag (workaround not possible this time).


TagsNo tags attached.
Checked infolog.txt for Errors

Activities

abma

2010-12-11 00:11

administrator   ~0006054

Two users reported this today in #sy:

@Licho:

 MelBot: <Phantasm> Ok, so someone broke either lobby server or TASClient... Not sure which yet and I'm too tired to do anything today. Anyway the problem is that people are getting LAN IP from autohost and Spads nor my config hasn't changed recently, so problem can't be there.

<[CN]Doxie> Well... I have no clue why it's suddenly reporting it's local IP to the clients instead of the WAN IP...

Licho

2010-12-11 00:14

reporter   ~0006055

That was separate issue in uberserver, I fixed that already.

Licho

2010-12-11 00:14

reporter   ~0006056

(They need to reconnect)

Kloot

2010-12-11 00:56

developer   ~0006057

implemented, test git-head bitte

Licho

2010-12-12 02:36

reporter   ~0006063

I tested with spring-dedicated from Spring 0.82+.4.0 (0.82.3-1030-g4cf9786)

It didn't seem to work.
Do I have correct version?

I have "HostIP" in script for dedicated server

Kloot

2010-12-12 13:21

developer   ~0006064

I forgot to update the dedserv, done now.

abma

2010-12-14 12:13

administrator   ~0006078

@Licho: did you retry with kloot's changes?

Licho

2010-12-15 02:12

reporter   ~0006079

Verified, works :)

abma

2010-12-15 10:50

administrator   ~0006080

kloot implemented/fixed it with https://github.com/spring/spring/commit/42390a434bae6e6066945b24386a77bc3443dff3

Issue History

Date Modified Username Field Change
2010-12-10 01:09 Licho New Issue
2010-12-10 02:10 abma Description Updated
2010-12-11 00:11 abma Note Added: 0006054
2010-12-11 00:14 Licho Note Added: 0006055
2010-12-11 00:14 Licho Note Added: 0006056
2010-12-11 00:56 Kloot Note Added: 0006057
2010-12-11 00:56 Kloot Status new => feedback
2010-12-12 02:36 Licho Note Added: 0006063
2010-12-12 13:21 Kloot Note Added: 0006064
2010-12-14 12:13 abma Note Added: 0006078
2010-12-15 02:12 Licho Note Added: 0006079
2010-12-15 10:50 abma Note Added: 0006080
2010-12-15 10:50 abma Status feedback => resolved
2010-12-15 10:50 abma Fixed in Version => 0.82.6.1+git
2010-12-15 10:50 abma Resolution open => fixed
2010-12-15 10:50 abma Assigned To => abma
2010-12-15 10:50 abma Assigned To abma => Kloot