View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002055 | Spring engine | General | public | 2010-08-23 09:59 | 2010-08-23 18:32 |
| Reporter | abma | Assigned To | Kloot | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.82.3+git | ||||
| Fixed in Version | 0.82.3+git | ||||
| Summary | 0002055: segfault in SpringApp.cpp:1219 on game quit | ||||
| Description | current spring/master segfaults always on quit: #0 0x00007fff00ff0105 in ?? () #1 0x0000000000d7e29d in SpringApp::Shutdown () at /home/matze/svn/spring/rts/System/SpringApp.cpp:1219 #2 0x0000000000d7e22f in SpringApp::Run (this=0x7fffffffe6d0, argc=1, argv=0x7fffffffe868) at /home/matze/svn/spring/rts/System/SpringApp.cpp:1208 0000003 0x0000000000da4dcc in Run (argc=1, argv=0x7fffffffe868) at /home/matze/svn/spring/rts/System/Main.cpp:52 0000004 0x0000000000da502d in main (argc=1, argv=0x7fffffffe868) at /home/matze/svn/spring/rts/System/Main.cpp:70 | ||||
| Additional Information | looks like an duplicate "delete loadscreen;" $ grep -R "delete loadscreen" rts/ rts/System/SpringApp.cpp: delete loadscreen; rts/Game/Game.cpp: delete loadscreen; //! don't use SafeDelete here (the loadscreen pointer is used IN the destructor!) | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
incorrect neither reproducable with local builds nor with http://springrts.com/dl/buildbot/default/master/0.82.3-154-gadce7d9/ Try a full clean rebuild. |
|
|
Not "incorrect", it is fully reproducable here also. SpringApp::Shutdown() delete loadscreen; delete game; CGame::~CGame delete loadscreen; |
|
|
the destructor of CLoadScreen sets loadscreen to NULL and delete handles NULL pointers fine, so deleting it twice is legal. |
|
|
You're right, but it nevertheless crashes in Shutdown (with a clean build). Unfortunately the stacktrace is useless, seems to be somewhere in ~CGame. |
|
|
Still I don't get a crash, so it's either your settings or your os. |
|
|
It was your code, because the crash went away with http://github.com/spring/spring/commit/a3639c37d7cfea81756b719a121e4f5676a8a26a . |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-08-23 09:59 | abma | New Issue | |
| 2010-08-23 10:00 | abma | Summary | segfault in SpringApp.cpp:1219 => segfault in SpringApp.cpp:1219 on game quit |
| 2010-08-23 12:04 | jK | Note Added: 0005351 | |
| 2010-08-23 12:04 | jK | Note Edited: 0005351 | |
| 2010-08-23 12:43 | Kloot | Note Added: 0005352 | |
| 2010-08-23 12:47 | jK | Note Added: 0005353 | |
| 2010-08-23 12:57 | Kloot | Note Added: 0005354 | |
| 2010-08-23 12:58 | Kloot | Note Edited: 0005354 | |
| 2010-08-23 15:41 | jK | Note Added: 0005356 | |
| 2010-08-23 18:32 | Kloot | Note Added: 0005358 | |
| 2010-08-23 18:32 | Kloot | Status | new => resolved |
| 2010-08-23 18:32 | Kloot | Fixed in Version | => 0.82.3+git |
| 2010-08-23 18:32 | Kloot | Resolution | open => fixed |
| 2010-08-23 18:32 | Kloot | Assigned To | => Kloot |
