View Issue Details

IDProjectCategoryView StatusLast Update
0002046Spring engineGeneralpublic2010-08-30 22:25
ReporterRafal99 Assigned Tozerver  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.82.3 
Fixed in Version0.82.3+git 
Summary0002046: Replays desync from original game because synced lua sees player who watches replay
DescriptionIt seems that synced Lua sees player who watches replay, so callings returning player list return different list than in original game, and any synced lua code relying on it will behave differently in the replay. Probably unintended.
Additional InformationI have not tested this properly yet but this is my conclusion from trying to watch CA replays which are currently broken.
CA currently has a bug which spawns additional commanders for each of the spectators. I played a game with no spectators no additional coms were spawned, then watched replay and one additional com was spawned, which means spectator watching replay (me) was visible to the lua.
TagsNo tags attached.
Checked infolog.txt for Errors

Relationships

related to 0002041 resolvedzerver The game was fine, but the replay desyncs 

Activities

zerver

2010-08-19 18:07

reporter   ~0005318

I have not noticed any extra coms spawned in BA, and as long as these extra users are spectators, there should not be a problem WRT sync I think. You are correct though that if you use the player count (including specs) in synced code, the demo will desync for sure.

So right now I'm thinking this is a CA bug only and the desync you see is because of that bug (the extra coms).

zerver

2010-08-30 22:25

reporter   ~0005402

http://github.com/spring/spring/commit/6d446dfd5179040ddce3a466573dcf6474a1659d

Issue History

Date Modified Username Field Change
2010-08-19 11:48 Rafal99 New Issue
2010-08-19 18:07 zerver Note Added: 0005318
2010-08-23 22:55 zerver Relationship added related to 0002041
2010-08-30 22:25 zerver Note Added: 0005402
2010-08-30 22:25 zerver Status new => resolved
2010-08-30 22:25 zerver Fixed in Version => 0.82.3+git
2010-08-30 22:25 zerver Resolution open => fixed
2010-08-30 22:25 zerver Assigned To => zerver