View Issue Details

IDProjectCategoryView StatusLast Update
0001998Spring engineGeneralpublic2010-07-25 05:31
Reporterhoijui Assigned TojK  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Target Version0.82.0Fixed in Version0.81.2+git 
Summary0001998: No more commanders
Descriptionin current master build, with BA 7.13 beta, the commanders do not spawn anymore, again. Happens with both my own linux build, and the buildbot windows build.
i guess they still do in the testbuild, so must have been a recent change.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Kloot

2010-07-24 17:27

developer   ~0005148

It's because BA 7.13's LuaRules/main.lua still tries to call AllowUnsafeChanges which no longer exists.

hoijui

2010-07-24 17:39

reporter   ~0005149

and the best solution is to tell TFC to remove that?

SirMaverick

2010-07-24 17:44

reporter   ~0005150

Last edited: 2010-07-24 17:44

AllowUnsafeChanges was removed, but is still checked.

With CA I get (calling CreateUnit from GameStart):
LuaRules::RunCallIn: error = 2, GameStart, [string "LuaRules/Gadgets/start_unit_setup.lua"]:355: Unsafe attempt to change game state
stack traceback:
        [C]: in function 'CreateUnit'
        [string "LuaRules/Gadgets/start_unit_setup.lua"]:355: in function 'SpawnStartUnit'
        [string "LuaRules/Gadgets/start_unit_setup.lua"]:542: in function 'GameStart'
        [string "LuaRules/gadgets.lua"]:1063: in function <[string "LuaRules/gadgets.lua"]:1061>
        (tail call): ?

hoijui

2010-07-24 17:55

reporter   ~0005151

yeah.. i removed it from BA, and still no comms

FLOZi

2010-07-25 02:10

reporter   ~0005155

Same issue with S44; with AUC there's a 'attempt to call global 'AllowUnsafeChanges' (a nil value)' error, and without it, the 'Unsafe attempt to change game state' error. Definitely an oversight in the removal of AUC somewhere.

jK

2010-07-25 05:30

developer   ~0005156

yeah, AUC wasn't working at GameStart (:= before a synced-only callin was called)

Issue History

Date Modified Username Field Change
2010-07-24 16:08 hoijui New Issue
2010-07-24 17:27 Kloot Note Added: 0005148
2010-07-24 17:39 hoijui Note Added: 0005149
2010-07-24 17:44 SirMaverick Note Added: 0005150
2010-07-24 17:44 SirMaverick Note Edited: 0005150
2010-07-24 17:55 hoijui Note Added: 0005151
2010-07-25 02:10 FLOZi Note Added: 0005155
2010-07-25 05:30 jK Note Added: 0005156
2010-07-25 05:30 jK Status new => resolved
2010-07-25 05:30 jK Fixed in Version => 0.81.2+git
2010-07-25 05:30 jK Resolution open => fixed
2010-07-25 05:30 jK Assigned To => jK