| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001985 | Spring engine | General | public | 2010-07-15 04:16 | 2010-07-17 11:58 | ||||
| Reporter | smoth | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.81.2+git | ||||||||
| Target Version | Fixed in Version | 0.81.0.0+git | |||||||
| Summary | 0001985: Shadow mode 2 now broken. | ||||||||
| Description | Shadow mode 2 now works as shadow mode 1 | ||||||||
| Additional Information | Sometime after build: 0.81.2.1-1270-ga29f85f happens for sure at build: 0.81.2.1-1271-ga9d0e26 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
smoth (reporter) 2010-07-15 04:29 |
Correction Sometime after build: 0.81.2.1-1271-ga9d0e26 happens for sure at build: 0.81.2.1-1282-g3d976f5 |
|
Kloot (developer) 2010-07-15 11:18 Last edited: 2010-07-15 11:29 |
Seems to be nothing wrong with it (see shadows*.png)? |
|
smoth (reporter) 2010-07-15 20:20 |
you are not looking at feature shadows. |
|
Kloot (developer) 2010-07-15 21:24 Last edited: 2010-07-15 21:24 |
Ah, now this makes sense. But your report is still misleading: In mode 1, (3D) trees and terrain should both cast shadows. In mode 2, terrain should not cast any shadows, but trees should. However, in the current release build, trees actually cast shadows *just for their stalks* when in mode 2 (a bug), but look fine in mode 1. In git-master builds, trees cast shadows *just for their stalks* in modes 2 AND 1 (another bug). Therefore it is mode 1 that got broken, not 2. |
|
Kloot (developer) 2010-07-15 21:51 |
fixed (both modes) |
|
smoth (reporter) 2010-07-16 17:15 |
Shadow mode 1 still broken Try beheriths map moor. http://springrts.com/phpbb/viewtopic.php?f=13&t=23411 notice the pinetrees only have shadows for their trunks. |
|
Kloot (developer) 2010-07-17 11:57 |
Fixed. For my own reference: unit shadows are also broken again as a result of http://github.com/spring/spring/commit/1680b6d12d94ef67c5ecaeb763993730f81a5617 (cf UnitShadows-f1f3876ef9a24e67bd90f432d9e54c8b364e7ba6.png). |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-15 04:16 | smoth | New Issue | |
| 2010-07-15 04:29 | smoth | Note Added: 0005100 | |
| 2010-07-15 11:17 | Kloot | File Added: shadows1-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png | |
| 2010-07-15 11:18 | Kloot | File Added: shadows2-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png | |
| 2010-07-15 11:18 | Kloot | Note Added: 0005101 | |
| 2010-07-15 11:29 | Kloot | Note Edited: 0005101 | |
| 2010-07-15 20:14 | smoth | File Added: currentreleasesh1.png | |
| 2010-07-15 20:15 | smoth | File Added: currentreleasesh2.png | |
| 2010-07-15 20:19 | smoth | File Added: 0.81.2.1-1282-g3d976f5_sh1.png | |
| 2010-07-15 20:20 | smoth | File Added: 0.81.2.1-1282-g3d976f5_sh2.png | |
| 2010-07-15 20:20 | smoth | Note Added: 0005103 | |
| 2010-07-15 21:24 | Kloot | Note Added: 0005104 | |
| 2010-07-15 21:24 | Kloot | Note Edited: 0005104 | |
| 2010-07-15 21:51 | Kloot | Note Added: 0005105 | |
| 2010-07-15 21:51 | Kloot | Status | new => resolved |
| 2010-07-15 21:51 | Kloot | Fixed in Version | => 0.81.0.0+git |
| 2010-07-15 21:51 | Kloot | Resolution | open => fixed |
| 2010-07-15 21:51 | Kloot | Assigned To | => Kloot |
| 2010-07-16 17:15 | smoth | Note Added: 0005107 | |
| 2010-07-16 17:15 | smoth | Status | resolved => assigned |
| 2010-07-16 17:15 | smoth | Resolution | fixed => reopened |
| 2010-07-17 11:57 | Kloot | Note Added: 0005114 | |
| 2010-07-17 11:58 | Kloot | File Added: UnitShadows-f1f3876ef9a24e67bd90f432d9e54c8b364e7ba6.png | |
| 2010-07-17 11:58 | Kloot | Status | assigned => resolved |
| 2010-07-17 11:58 | Kloot | Resolution | reopened => fixed |
| Issue History |