View Issue Details

IDProjectCategoryView StatusLast Update
0001926Spring engineUnit Scriptingpublic2013-10-27 22:26
ReporterGoogle_Frog Assigned ToKloot  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.81.2 
Fixed in Version94.1.1+git 
Summary0001926: Lua Script callin broken for gunships
Descriptionscript.StartMoving() and script.StopMoving() do not produce expected behaviour for gunships.

script.StopMoving() is called when the gunship starts landing and when it finishes landing.

script.StartMoving() is not called if the gunship is given a move order after it starts landing and before it has finished landing.

I suggest to change StopMoving() to be called when the gunship starts landing and StartMoving() to be called when the gunship, well, starts moving. Two new callins for takeoff and landing could be added to patch the functionality that might be lost from restricting start and stop moving.
Additional InformationVery simple test

function script.StartMoving()
    Spring.Echo("START moving")
end

function script.StopMoving()
    Spring.Echo("stop moving")
end
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

Google_Frog

2010-05-27 12:06

reporter   ~0004939

This can be worked around by using Activate() in place of StartMoving() though that has conflict issues if someone wants to make a gunship with On/Off state and an animation on landing.

The workaround works for my current purpose though.

FLOZi

2010-05-28 19:14

reporter   ~0004940

Are you sure the behaviour is different to COB?

Google_Frog

2010-06-08 03:24

reporter   ~0004956

No.

Kloot

2013-10-27 22:26

developer   ~0011866

as of 95.0 the rules are:

StopMoving will be called when a gunship starts landing (this should still be replaced by a new callin) and whenever its speed becomes zero.

StartMoving will be called whenever a gunship's speed becomes non-zero.

Issue History

Date Modified Username Field Change
2010-05-15 04:37 Google_Frog New Issue
2010-05-27 12:06 Google_Frog Note Added: 0004939
2010-05-28 19:14 FLOZi Note Added: 0004940
2010-06-08 03:24 Google_Frog Note Added: 0004956
2013-10-27 22:26 Kloot Note Added: 0011866
2013-10-27 22:26 Kloot Status new => resolved
2013-10-27 22:26 Kloot Fixed in Version => 94.1.1+git
2013-10-27 22:26 Kloot Resolution open => fixed
2013-10-27 22:26 Kloot Assigned To => Kloot