| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001842 | Spring engine | General | public | 2010-02-16 12:51 | 2010-07-30 16:18 | ||||
| Reporter | hoijui | ||||||||
| Assigned To | zerver | ||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.81.1+git | ||||||||
| Target Version | Fixed in Version | 0.82.0+git | |||||||
| Summary | 0001842: dark metal spots on metal-view, escpecialy in water | ||||||||
| Description | git bisected, and found this commit to be the first bad one: http://github.com/spring/spring/commit/0c6c3b345c3a47bbbe0e50a177896d16a7de55fc also see screenshots | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
zerver (reporter) 2010-07-29 23:38 |
F4 view became a bit brighter after me fixing this, but I think it should be OK. http://github.com/spring/spring/commit/d27cb1db662f2360b0c1ab41bd6570c3c389cc78 |
|
jK (developer) 2010-07-30 01:02 |
> but I think it should be OK. It isn't you broke LOS view and others. |
|
zerver (reporter) 2010-07-30 01:07 |
Yes LOS view is brighter too, but does that mean broken :) |
|
jK (developer) 2010-07-30 01:13 Last edited: 2010-07-30 01:13 |
It isn't brighter, it is broken! The ExtraTexture is designed to be multiplied with the terrain, not to be signed_add. So if the ExtraTexture is blue, then the terrain should be blue and not random color + blue. |
|
jK (developer) 2010-07-30 01:19 |
You can't use GL_ADD_SIGNED at all. It is invisible on bright maps even for F4. |
|
zerver (reporter) 2010-07-30 01:20 |
KK, but in case of Metal View the texture is mostly black, so works for that at least. |
|
zerver (reporter) 2010-07-30 01:28 |
I guess I could multiply it by some constant instead to make it brighter for metal view. Or you have better suggestion? |
|
jK (developer) 2010-07-30 01:49 Last edited: 2010-07-30 14:23 |
I wanted to wait for dynamic recompilable shaders to multiply the waterplane with the extratexture and maybe to modify the terrain blending equation a bit. |
|
zerver (reporter) 2010-07-30 16:18 |
I tested with the brightest arctic maps I could find, and no problems. If you want to improve it later that's fine but right now the GL_ADD_SIGNED is producing a better looking metal map imo. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-02-16 12:51 | hoijui | New Issue | |
| 2010-02-16 12:51 | hoijui | File Added: good.jpeg | |
| 2010-02-16 12:52 | hoijui | File Added: bad.jpeg | |
| 2010-02-16 12:52 | hoijui | Description Updated | |
| 2010-02-22 20:05 | tvo | Target Version | 0.81.2 => |
| 2010-03-01 15:17 | tvo | Target Version | => 0.81.2.1 |
| 2010-04-15 13:49 | tvo | Target Version | 0.81.2.1 => |
| 2010-07-29 23:38 | zerver | Note Added: 0005180 | |
| 2010-07-29 23:38 | zerver | Status | new => resolved |
| 2010-07-29 23:38 | zerver | Fixed in Version | => 0.82.0+git |
| 2010-07-29 23:38 | zerver | Resolution | open => fixed |
| 2010-07-29 23:38 | zerver | Assigned To | => zerver |
| 2010-07-30 01:02 | jK | Note Added: 0005182 | |
| 2010-07-30 01:02 | jK | Status | resolved => assigned |
| 2010-07-30 01:02 | jK | Resolution | fixed => reopened |
| 2010-07-30 01:07 | zerver | Note Added: 0005183 | |
| 2010-07-30 01:13 | jK | Note Added: 0005184 | |
| 2010-07-30 01:13 | jK | Note Edited: 0005184 | |
| 2010-07-30 01:19 | jK | Note Added: 0005185 | |
| 2010-07-30 01:20 | zerver | Note Added: 0005186 | |
| 2010-07-30 01:20 | zerver | Status | assigned => resolved |
| 2010-07-30 01:20 | zerver | Resolution | reopened => fixed |
| 2010-07-30 01:28 | zerver | Note Added: 0005187 | |
| 2010-07-30 01:28 | zerver | Status | resolved => assigned |
| 2010-07-30 01:28 | zerver | Resolution | fixed => reopened |
| 2010-07-30 01:49 | jK | Note Added: 0005188 | |
| 2010-07-30 14:23 | jK | Note Edited: 0005188 | |
| 2010-07-30 16:18 | zerver | Note Added: 0005189 | |
| 2010-07-30 16:18 | zerver | Status | assigned => resolved |
| 2010-07-30 16:18 | zerver | Resolution | reopened => fixed |
| Issue History |