View Issue Details

IDProjectCategoryView StatusLast Update
0001715AIAIpublic2011-08-22 15:12
Reporterhoijui Assigned Tohoijui  
PrioritylowSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Summary0001715: Get rid of ugly big static array vars
Descriptionat the beginning in this file:
rts/ExternalAI/SSkirmishAICallbackImpl.cpp
Additional Informationstatic const size_t TMP_ARR_SIZE = 16384;
...
static int tmpIntArr[MAX_SKIRMISH_AIS][TMP_ARR_SIZE];
static PointMarker tmpPointMarkerArr[MAX_SKIRMISH_AIS][TMP_ARR_SIZE];
static LineMarker tmpLineMarkerArr[MAX_SKIRMISH_AIS][TMP_ARR_SIZE];
static const char* tmpKeysArr[MAX_SKIRMISH_AIS][TMP_ARR_SIZE];
static const char* tmpValuesArr[MAX_SKIRMISH_AIS][TMP_ARR_SIZE];
TagsNo tags attached.

Activities

hoijui

2011-08-22 15:12

reporter   ~0007267

resolved in:
https://github.com/spring/spring/commit/691ef32e42433470ea9fb4a2091c08d6d98fe106

This reduces constantly allocated memory from ~130MB to ~ 2KB
(for lines and points fetching by AIs).
Depending on which AIs are used and how much is drawn,
it may not likely raise above 10MB anymore.

Issue History

Date Modified Username Field Change
2009-10-31 21:35 hoijui New Issue
2009-10-31 21:35 hoijui Status new => assigned
2009-10-31 21:35 hoijui Assigned To => hoijui
2011-08-22 15:12 hoijui Note Added: 0007267
2011-08-22 15:12 hoijui Status assigned => resolved
2011-08-22 15:12 hoijui Resolution open => fixed