View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001675Spring engineGeneralpublic2009-10-10 11:312009-10-11 13:12
ReporterSirMaverick Assigned Tohoijui  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version0.80.4.0+git 
Summary0001675: fake NETMSG_STARTPOS
DescriptionNETMSG_STARTPOS can be faked. It's checked that the message come from the right player, but the team id (only checked for bounds) is used for the start pos. (So you can already see in game who is faking the message.)

This works even after the player is readied up. Anyone (players and specs) can fake the message.
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

hoijui

2009-10-11 13:12

reporter   ~0004204

fixed with commit: 6e1c8931dbb5985b663feee3cae5c21270afad70

additional check introduced:
if (!cheating &&
    (team != players[player].team) &&
    (teams[team].leader != player) &&
    (getSkirmishAIIds(ais, team, player).size() == 0)) {
   // ignore message
}

Issue History

Date Modified Username Field Change
2009-10-10 11:31 SirMaverick New Issue
2009-10-11 13:12 hoijui Note Added: 0004204
2009-10-11 13:12 hoijui Status new => resolved
2009-10-11 13:12 hoijui Fixed in Version => 0.80.4.0+git
2009-10-11 13:12 hoijui Resolution open => fixed
2009-10-11 13:12 hoijui Assigned To => hoijui