View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001637 | Spring engine | Linux | public | 2009-09-09 14:24 | 2014-01-03 01:05 |
| Reporter | Xytovl | Assigned To | abma | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | won't fix | ||
| Target Version | 0.81.0.0 | ||||
| Summary | 0001637: [PATCH] Xinerama dualscreen in Linux | ||||
| Description | This patch allows use of xinerama to detect screen geometry. It allows screens to be different and correctly map the view and map on each device. | ||||
| Additional Information | It does not work if the main screen is smaller (in height) than the map screen due to ViewPosY apparently not being used. I am not used to cmake, so I have added USE_XINERAMA as a default value, without checking for Linux as well, this should be changed. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
having a look at it for the future, it would be nicer if you forked spring on github and pushed your changes there. credits for the changes would then go to you, and i/we would have less work :D |
|
|
I tried this, seems to (sort of) work for me, although one time minimap was on wrong side (may happen if primary monitor is to the right of secondary monitor maybe?) I think it needs a setting to set primary screen for Spring, I don't like having to change it in X server, as that also changes locations of panels etc. (i.e. in gnome) Also this patch introduces a lot of code duplication, please factor as much as possible out into a function. |
|
|
Here is a new version with no code replication and that should work when the main display is not on the left |
|
|
I forgot to say that v2 of the patch has USE_XINERAMA disabled by default |
|
|
Ah great, this looks a lot cleaner already :-) |
|
|
Added the work-in-progress support for asymetric setups with the main screen that is smaller (in height) than the minimap screen. Everything seems to work except movement orders given on the minimap, there is an offset I can't fix :( |
|
|
Added the missing cmake file needed to find the library ... it would not compile without it you should apply xinerama-spring-v2.patch and xinerama-cmake.patch together xinerama-small-viewSizeY.patch can be applied as well, but it seems that some lua scripts are broken if viewsizeY is smaller than the screen height, so it is not totally usable. |
|
|
why wasn't this patch applied/decilined? |
|
|
patch doesn't apply any more, also not sure if SDL2 fixes some problems here (see SDL2 branch at github) next time please use github, this way patches are more likely applied. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-09-09 14:24 | Xytovl | New Issue | |
| 2009-09-09 14:24 | Xytovl | File Added: xinerama-spring.patch | |
| 2009-10-03 10:46 | imbaczek | Target Version | => 0.81.0.0 |
| 2009-11-16 13:44 | hoijui | Note Added: 0004337 | |
| 2010-01-15 00:14 | tvo | Note Added: 0004494 | |
| 2010-01-15 14:31 | Xytovl | File Added: xinerama-spring-v2.patch | |
| 2010-01-15 14:32 | Xytovl | Note Added: 0004495 | |
| 2010-01-16 21:30 | Xytovl | Note Added: 0004498 | |
| 2010-01-17 11:49 | tvo | Note Added: 0004500 | |
| 2010-01-18 11:53 | Xytovl | File Added: xinerama-small-viewSizeY.patch | |
| 2010-01-18 11:55 | Xytovl | Note Added: 0004507 | |
| 2010-01-20 18:29 | Xytovl | File Added: xinerama-cmake.patch | |
| 2010-01-20 18:33 | Xytovl | Note Added: 0004514 | |
| 2012-11-04 02:02 | abma | Note Added: 0009302 | |
| 2012-11-04 02:02 | abma | Status | new => feedback |
| 2014-01-03 01:05 | abma | Note Added: 0012578 | |
| 2014-01-03 01:05 | abma | Status | feedback => resolved |
| 2014-01-03 01:05 | abma | Resolution | open => won't fix |
| 2014-01-03 01:05 | abma | Assigned To | => abma |
