| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001442 | Spring engine | Lua | public | 2009-06-02 03:10 | 2009-06-02 17:31 | ||||
| Reporter | jK | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.79.1.0+git | ||||||||
| Target Version | Fixed in Version | 0.79.1.0+git | |||||||
| Summary | 0001442: enum COLVOL_TESTS doesn't use consts | ||||||||
| Description | the COLVOL_TESTS enum doesn't use constants, but is directly read in unit- and featureDefs, so the use of them isn't predictable in future versions. CollisionVolume.h: enum COLVOL_TESTS { COLVOL_TEST_DISC, COLVOL_TEST_CONT, COLVOL_NUM_TESTS } UnitDefHandler.cpp: ud.collisionVolumeTest = udTable.GetInt("collisionVolumeTest", COLVOL_TEST_DISC); | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2009-06-02 15:37 Last edited: 2009-06-02 15:38 |
I don't have a plans for a third type of test, but if I were to add another it would be inserted between TEST_CONT and NUM_TESTS to preserve the current implicit DISC=0, CONT=1 mapping. This isn't an engine area that changes a lot anyway, so I think that's safe enough. |
|
Kloot (developer) 2009-06-02 17:31 |
done now anyway |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-06-02 03:10 | jK | New Issue | |
| 2009-06-02 15:37 | Kloot | Note Added: 0003587 | |
| 2009-06-02 15:38 | Kloot | Note Edited: 0003587 | |
| 2009-06-02 17:31 | Kloot | Note Added: 0003589 | |
| 2009-06-02 17:31 | Kloot | Status | new => resolved |
| 2009-06-02 17:31 | Kloot | Fixed in Version | => 0.79.1.0+git |
| 2009-06-02 17:31 | Kloot | Resolution | open => fixed |
| 2009-06-02 17:31 | Kloot | Assigned To | => Kloot |
| Issue History |