| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001413 | Spring engine | Unit Scripting | public | 2009-05-25 19:18 | 2009-05-29 00:30 | ||||
| Reporter | TheFatController | ||||||||
| Assigned To | tvo | ||||||||
| Priority | normal | Severity | feature | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.79.0.2+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0001413: 2 Issues with COB and exploding units | ||||||||
| Description | Firstly: http://github.com/spring/spring/blob/5221fe363bd61dc3ecb3e23c2e4cd3885ee4bbd0/rts/Sim/Units/COB/CobInstance.cpp#L935 There's a default engine fireball when a piece explodes, for organic units this means you can't have exploding pieces as a fireball looks unsuitable, i'd suggest making this a customisable ceg and not hard coded. Secondly: having a custom pieceTrailCEGTag for a unit is cool but on exploding parts it doesn't obey the 'SMOKE' option and is always displayed, it should only display if SMOKE is specified eg: explode radar type FALL | SMOKE | EXPLODE_ON_HIT | BITMAP5; = show the pieceTrailCEGTag explode radar type FALL | EXPLODE_ON_HIT | BITMAP5; = don't show the pieceTrailCEGTag Thanks! | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2009-05-25 19:25 |
@2nd request: PieceProjectile.h: const int PF_NoCEGTrail = (1 << 6); |
|
tvo (reporter) 2009-05-27 23:12 |
The first thing would only need a flag to disable the hardcoded explosion right? (You could just do emit-sfx before explode, I think) |
|
tvo (reporter) 2009-05-29 00:30 |
implemented in http://github.com/spring/spring/commit/e1d3841d5020359c2ef209e210340712e3d00315 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-05-25 19:18 | TheFatController | New Issue | |
| 2009-05-25 19:25 | jK | Note Added: 0003482 | |
| 2009-05-27 23:12 | tvo | Note Added: 0003520 | |
| 2009-05-29 00:25 | tvo | Status | new => assigned |
| 2009-05-29 00:25 | tvo | Assigned To | => tvo |
| 2009-05-29 00:30 | tvo | Note Added: 0003543 | |
| 2009-05-29 00:30 | tvo | Status | assigned => resolved |
| 2009-05-29 00:30 | tvo | Resolution | open => fixed |
| Issue History |