View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001199 | Spring engine | General | public | 2008-11-08 14:49 | 2010-07-14 14:27 |
| Reporter | momfreeek | Assigned To | zerver | ||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.77b5+svn | ||||
| Fixed in Version | 0.82.0 | ||||
| Summary | 0001199: [patch] mouse behaviour fix | ||||
| Description | a few simple changes to GuiHandler.cpp. New behaviour: Gui items (buildpics etc) register mouse clicks on MousePress rather than MouseRelease. Previous behaviour made it very easy to select the wrong buildpic if you moved the mouse fast. Also when performing a drag operation with the mouse (such as area reclaim) releasing the mouse over the gui no longer cancels the drag. The drag command is performed and the gui element is ignored. see issue here: http://spring.clan-sy.com/phpbb/viewtopic.php?f=21&t=15867 I did a few tests. general mouse use & interactions with luaui, minimap, units etc all seem to work fine. I'm not very familiar with the code but the gui code seems fairly self contained and I couldn't see any potential issues. Hope I might be able to use this with the new hardware cursor, how does it look? | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
this is still not in master in my eyes, this patch is 50/50 good/bad, because: when pressing on button A and releasing on button B, the current system activates button B (bad). The new patch does not do this (good), but it activates button A instead (bad too in my eyes, good in momfreeek's eyes). |
|
|
http://github.com/spring/spring/commit/d1a912e9c361857b41aab5c677e41be5ce381c2b |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-11-08 14:49 | momfreeek | New Issue | |
| 2008-11-08 14:49 | momfreeek | File Added: GuiHandler.patch | |
| 2009-05-20 12:48 | tvo | Summary | mouse behaviour fix => [patch] mouse behaviour fix |
| 2009-07-25 11:51 | hoijui | Note Added: 0003764 | |
| 2010-07-14 14:27 | jK | Status | new => assigned |
| 2010-07-14 14:27 | jK | Assigned To | => zerver |
| 2010-07-14 14:27 | jK | Note Added: 0005098 | |
| 2010-07-14 14:27 | jK | Status | assigned => resolved |
| 2010-07-14 14:27 | jK | Fixed in Version | => 0.82 |
| 2010-07-14 14:27 | jK | Resolution | open => fixed |
