2025-11-08 10:53 CET
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000667Spring engineGeneralpublic2007-10-30 21:262007-11-03 16:41
Reporterrattle 
Assigned Toimbaczek 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000667: COB: set ACTIVATION fix
DescriptionChanges unit->Activation()/Deactivation() to issue a command to the unit rather than calling the functions directly. On/Off button state will not change otherwise.

Tested and works.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • patch file icon ACTIVATION_OnOff_Button_Toggle.patch (497 bytes) 2007-10-30 21:26 - 
    Index: CobInstance.cpp
===================================================================
--- CobInstance.cpp	(revision 4665)
+++ CobInstance.cpp	(working copy)
@@ -1151,10 +1151,11 @@
 #ifndef _CONSOLE
 	switch(val) {
 		case ACTIVATION: {
-			if (param == 0) {
-				unit->Deactivate();
-			} else {
-				unit->Activate();
+			if (param == 0 || param == 1) {
+				Command c;
+				c.id = CMD_ONOFF;
+				c.params.push_back(param);
+				unit->commandAI->GiveCommand(c);
 			}
 			break;
 		}
    patch file icon ACTIVATION_OnOff_Button_Toggle.patch (497 bytes) 2007-10-30 21:26 +

-Relationships
+Relationships

-Notes

~0001400

imbaczek (reporter)

2007-11-03 16:41

 looks good. committed in r4693.
+Notes

-Issue History
Date Modified Username Field Change
2007-10-30 21:26 rattle New Issue
2007-10-30 21:26 rattle File Added: ACTIVATION_OnOff_Button_Toggle.patch
2007-11-03 16:41 imbaczek Status new => resolved
2007-11-03 16:41 imbaczek Resolution open => fixed
2007-11-03 16:41 imbaczek Assigned To => imbaczek
2007-11-03 16:41 imbaczek Note Added: 0001400
+Issue History