View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005798Spring engineGeneralpublic2017-10-04 19:532017-10-12 12:42
Reporterapoleon Assigned Tohokomoko  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version104.0 
Summary0005798: Please make the build reproducible
DescriptionCurrently the spring engine cannot be built reproducibly. There are several advantages when a piece of software can be built in a reproducible way. More information can be found at https://wiki.debian.org/ReproducibleBuilds.

Please find attached a patch for one known issue when spring is built in different timezones.
Steps To ReproduceRebuild spring in different timezones.
TagsNo tags attached.
Attached Files
reproducible.patch (Attachment missing)
Checked infolog.txt for Errors

Activities

apoleon

2017-10-04 19:56

reporter   ~0018471

Here you can find more information about the current reproducible build result.

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/spring.html

abma

2017-10-05 12:41

administrator   ~0018472

Fix 68227f1a0d37defef61ce955d76bc6baf0f50f29 committed to develop branch: fix 0005798:

apply patch for reproducible builds, repo: spring changeset id: 8903

abma

2017-10-05 12:42

administrator   ~0018473

thanks for the patch!

FYI: we also accept pull requests: https://github.com/spring/spring/pulls

abma

2017-10-05 12:55

administrator   ~0018474


7z allows to store without timestamps: wouldn't that be the better solution here?

i.e.:

$ 7z a -mtm=off reproducible.patch.7z reproducible.patch

...

$ 7z l reproducible.patch.7z

   Date Time Attr Size Compressed Name
------------------- ----- ------------ ------------ ------------------------
                    ....A 808 486 reproducible.patch
------------------- ----- ------------ ------------ ------------------------
                                   808 486 1 files

apoleon

2017-10-05 13:01

reporter   ~0018475

I'm not sure. I only know that timestamps will make your build unreproducible. So turning them off is the best solution.

abma

2017-10-10 00:35

administrator   ~0018489

oh, bad idea: the affected files are zipped (-tzip) and zip doesn't support this param.

this could be changed but i would give your change a try first as switching to 7z could cause other problems.

please report back when your change doesn't for for some reason / more changes are needed. :)

abma

2017-10-11 00:37

administrator   ~0018501

https://github.com/spring/spring/commit/72e23c95782e54a53230870ead6161b7767c34b0

hokomoko

2017-10-12 12:31

developer   ~0018504

Fix 7236dd312311ab9059a76b5771530a4c1b80c390 committed to develop branch: Fix 0005798, repo: spring changeset id: 8981

hokomoko

2017-10-12 12:42

developer   ~0018505

Fix faa643929c768e50921dd247e29ce68b095d97d9 committed to develop branch: Fix 0005798 take 2, repo: spring changeset id: 8982

Issue History

Date Modified Username Field Change
2017-10-04 19:53 apoleon New Issue
2017-10-04 19:53 apoleon File Added: reproducible.patch
2017-10-04 19:56 apoleon Note Added: 0018471
2017-10-05 12:41 abma Changeset attached => spring develop 68227f1a
2017-10-05 12:41 abma Note Added: 0018472
2017-10-05 12:41 abma Assigned To => abma
2017-10-05 12:41 abma Status new => resolved
2017-10-05 12:41 abma Resolution open => fixed
2017-10-05 12:42 abma Note Added: 0018473
2017-10-05 12:55 abma Status resolved => feedback
2017-10-05 12:55 abma Resolution fixed => reopened
2017-10-05 12:55 abma Note Added: 0018474
2017-10-05 13:01 apoleon Note Added: 0018475
2017-10-05 13:01 apoleon Status feedback => assigned
2017-10-10 00:35 abma Status assigned => resolved
2017-10-10 00:35 abma Resolution reopened => fixed
2017-10-10 00:35 abma Note Added: 0018489
2017-10-11 00:37 abma Assigned To abma =>
2017-10-11 00:37 abma Status resolved => new
2017-10-11 00:37 abma Resolution fixed => reopened
2017-10-11 00:37 abma Note Added: 0018501
2017-10-12 12:31 hokomoko Changeset attached => spring develop 7236dd31
2017-10-12 12:31 hokomoko Note Added: 0018504
2017-10-12 12:31 hokomoko Assigned To => hokomoko
2017-10-12 12:31 hokomoko Status new => resolved
2017-10-12 12:31 hokomoko Resolution reopened => fixed
2017-10-12 12:42 hokomoko Changeset attached => spring develop faa64392
2017-10-12 12:42 hokomoko Note Added: 0018505