| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005427 | Spring engine | General | public | 2017-01-08 13:59 | 2017-01-21 13:00 | ||||
| Reporter | cleanrock | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 103.0 +git | |||||||
| Summary | 0005427: shadows broken | ||||||||
| Description | Terrain and unit shadows have been broken for a few weeks for me now. If you can't reproduce this I will add more info. | ||||||||
| Steps To Reproduce | Take a look at terrain shadows when zoomed in a bit. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2017-01-08 15:15 |
screenshots? |
|
cleanrock (reporter) 2017-01-15 08:05 |
Added a few more screenshots. |
|
Kloot (developer) 2017-01-15 15:40 |
looks like an inverted z comparison, but shadows render normally for me so there is some unaccounted difference in behavior. engine build? driver version? infolog? |
|
cleanrock (reporter) 2017-01-15 15:54 |
I have seen this on latest spring/develop for about a month, I bet it is my gcc 6.3.1 that expose a spring bug. |
|
cleanrock (reporter) 2017-01-18 06:05 |
gajop, I am pretty sure you run archlinux, do you also see issues with shadows ? |
|
hokomoko (developer) 2017-01-18 10:09 |
Still no infolog, no exact steps taken to reproduce (what game etc.) no attempt to see if happens on clean build (remove all game/spring configs). My bet is that it's not gcc. |
|
cleanrock (reporter) 2017-01-18 17:40 |
Tested a bit more, the downloaded (built by spring build bot) 103.0.1-511-g12f211a do not show this issue but my locally rebuilt 103.0.1-511-g12f211a show issue in both ZK and BA. I may get the energy for a bisect some time, not sure if that will help though. Still would be interesting to hear if gajop also see this issue on archlinux. Attaching infolog of local 103.0.1-511-g12f211a in case it shows anything of interest. |
|
Kloot (developer) 2017-01-18 18:20 |
Pass VERBOSE=1 to make and check for any warnings generated by rendering code. |
|
cleanrock (reporter) 2017-01-20 13:15 |
I think this is a minor issue since problem is not seen in build bot builds which players use. Perhaps it is even a local issue for me but I still prefer some feedback from gajop. I think we can ignore this bug report until if/when it is seen by more users. |
|
Kloot (developer) 2017-01-20 13:30 Last edited: 2017-01-20 13:30 |
Assuming there is a compiler relationship I do not want to see this issue pop up again years later if / when buildbot is updated to gcc6 and everybody has forgotten about it, best to find out all relevant details now. |
|
Google_Frog (reporter) 2017-01-21 10:34 |
I have broken shadows with 64 bit windows Spring in 103.0.1-516-g0ffb9de. I think 103.0.1-298-gaf1edb1 works fine but I may not have noticed a problem. All shadows are broken: units, features and terrain. It looks like the sun is coming from the opposite direction than normal. If I zoom out or angle the camera up the shadows disappear completely (this might be due to the particular sun settings of the map). The map in my screenshots is Fields of Isis. Licho told me that if you let your computer go to sleep with 64 bit windows Spring running the Spring window will be black until resized. I've yet to try to reproduce but it may be related. |
|
Google_Frog (reporter) 2017-01-21 10:56 |
Here is some bisecting. 103.0.1-516-g0ffb9de broken shadows. 103.0.1-390-ga808bf1 broken shadows. 103.0.1-383-g8627c46 broken shadows. 103.0.1-375-g3a665b4 freeze on startup. 103.0.1-369-g9588c7f freeze on startup. 103.0.1-367-g9107506 no win64 build (same for 368). 103.0.1-360-g3b04435 working shadows. 103.0.1-345-g62b3749 working shadows. 103.0.1-298-gaf1edb1 working shadows. |
|
Google_Frog (reporter) 2017-01-21 11:06 |
103.0.1-365-g1c96edc broken shadows. 103.0.1-364-g947dab8 broken shadows. Looking at commit contents I think that this is responsible: https://github.com/spring/spring/commit/947dab8b1e7484287776cc329050359a79101f70 Windows 32 bit 103.0.1-364-g947dab8 has working shadows. |
|
hokomoko (developer) 2017-01-21 11:12 |
Thanks GF, that points the reason. Win64 builds use a different gl/glew headers which enables more GL extensions and same for cleanrock's build (which uses the system's headers). |
|
Google_Frog (reporter) 2017-01-21 11:12 |
My screenshots look like they have the same issue as cleanrock has. However he has had the issue "for a few weeks" which may mean during normal games. Zero-K has mostly run 103.0.1-298-gaf1edb1 which is outside the range. cleanrock, you should say which engine versions have this issue and/or try to bisect. |
|
cleanrock (reporter) 2017-01-21 11:46 Last edited: 2017-01-21 11:48 |
Indeed, reverting 947dab8b fixes this issue for me. I am curious to know why none of the devs have seen this issue with their local builds. |
|
Kloot (developer) 2017-01-21 12:03 Last edited: 2017-01-21 12:52 |
glClipControl is a recent GL extension and older drivers (mine are a year behind) might just insert a no-op while claiming to support it. even so it seems I forgot to adjust the shadow matrix. |
|
Kloot (developer) 2017-01-21 12:38 |
those affected: test 5a3e3616e please |
|
cleanrock (reporter) 2017-01-21 12:47 |
5a3e3616e looks good here. |
|
Google_Frog (reporter) 2017-01-21 12:58 |
win64 build 103.0.1-518-g5a3e361 works for me. |
|
Kloot (developer) 2017-01-21 13:00 |
confirmed fixed |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-08 13:59 | cleanrock | New Issue | |
| 2017-01-08 15:15 | Kloot | Note Added: 0017030 | |
| 2017-01-08 16:00 | cleanrock | File Added: screen00055.png | |
| 2017-01-15 08:03 | cleanrock | File Deleted: screen00055.png | |
| 2017-01-15 08:03 | cleanrock | File Added: screen00055.jpeg | |
| 2017-01-15 08:04 | cleanrock | File Added: screen00060.jpeg | |
| 2017-01-15 08:04 | cleanrock | File Added: screen00063.jpeg | |
| 2017-01-15 08:05 | cleanrock | Note Added: 0017047 | |
| 2017-01-15 15:40 | Kloot | Note Added: 0017050 | |
| 2017-01-15 15:54 | cleanrock | Note Added: 0017051 | |
| 2017-01-16 17:46 | abma | Status | new => feedback |
| 2017-01-18 06:05 | cleanrock | Note Added: 0017064 | |
| 2017-01-18 06:05 | cleanrock | Status | feedback => new |
| 2017-01-18 10:09 | hokomoko | Note Added: 0017065 | |
| 2017-01-18 17:40 | cleanrock | File Added: infolog.txt | |
| 2017-01-18 17:40 | cleanrock | Note Added: 0017067 | |
| 2017-01-18 18:20 | Kloot | Note Added: 0017068 | |
| 2017-01-20 13:15 | cleanrock | Note Added: 0017077 | |
| 2017-01-20 13:30 | Kloot | Note Added: 0017078 | |
| 2017-01-20 13:30 | Kloot | Note Edited: 0017078 | View Revisions |
| 2017-01-21 10:34 | Google_Frog | File Added: brokenShadows1.jpg | |
| 2017-01-21 10:34 | Google_Frog | Note Added: 0017084 | |
| 2017-01-21 10:35 | Google_Frog | File Added: brokenShadows2.jpg | |
| 2017-01-21 10:56 | Google_Frog | Note Added: 0017085 | |
| 2017-01-21 11:06 | Google_Frog | Note Added: 0017086 | |
| 2017-01-21 11:12 | hokomoko | Note Added: 0017087 | |
| 2017-01-21 11:12 | Google_Frog | Note Added: 0017088 | |
| 2017-01-21 11:46 | cleanrock | Note Added: 0017089 | |
| 2017-01-21 11:48 | cleanrock | Note Edited: 0017089 | View Revisions |
| 2017-01-21 12:03 | Kloot | Note Added: 0017091 | |
| 2017-01-21 12:38 | Kloot | Note Added: 0017094 | |
| 2017-01-21 12:47 | cleanrock | Note Added: 0017097 | |
| 2017-01-21 12:52 | Kloot | Note Edited: 0017091 | View Revisions |
| 2017-01-21 12:58 | Google_Frog | Note Added: 0017098 | |
| 2017-01-21 13:00 | Kloot | Assigned To | => Kloot |
| 2017-01-21 13:00 | Kloot | Status | new => resolved |
| 2017-01-21 13:00 | Kloot | Resolution | open => fixed |
| 2017-01-21 13:00 | Kloot | Note Added: 0017100 | |
| 2017-01-21 13:00 | Kloot | Fixed in Version | => 103.0 +git |
| Issue History |